Skip to content

Commit 5939d2c

Browse files
A few minor changes[CPP-619][CPP-610][CPP-662] (#428)
* SwiftTableView cell padding, Update tab panel clip[CPP-619][CPP-622] * Hardcode height of top tabinfobar[CPP-610]
1 parent 9b966df commit 5939d2c

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

resources/Constants/Constants.qml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ QtObject {
9292
})
9393
readonly property string infoButtonIconPath: "qrc:/images/fontawesome/info-circle-solid.svg"
9494
readonly property color infoButtonIconColor: swiftLightGrey
95+
readonly property int height: 50
9596
}
9697

9798
logoPopup: QtObject {
@@ -261,6 +262,8 @@ QtObject {
261262
genericTable: QtObject {
262263
readonly property int headerZOffset: 100
263264
readonly property int padding: 2
265+
readonly property int leftPadding: 5
266+
readonly property int rightPadding: 5
264267
readonly property int borderWidth: 1
265268
readonly property int mouseAreaResizeWidth: 10
266269
readonly property int cellHeight: 25

resources/SettingsTabComponents/SettingsTable.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ Rectangle {
216216
font.bold: isHeaderRow(row)
217217
text: model.display
218218
elide: Text.ElideRight
219-
padding: Constants.genericTable.padding
219+
leftPadding: Constants.genericTable.leftPadding
220+
rightPadding: Constants.genericTable.rightPadding
220221
}
221222

222223
MouseArea {

resources/TableComponents/SwiftTableView.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ TableView {
7171
font: tableFont
7272
text: model.display
7373
elide: Text.ElideRight
74-
padding: Constants.genericTable.padding
74+
leftPadding: Constants.genericTable.leftPadding
75+
rightPadding: Constants.genericTable.rightPadding
7576
}
7677

7778
MouseArea {

resources/UpdateTab.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ MainTab {
9696
Layout.fillHeight: true
9797
border.width: Constants.updateTab.borderWidth
9898
border.color: Constants.genericTable.borderColor
99+
clip: true
99100

100101
ScrollView {
101102
anchors.fill: parent

resources/view.qml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ ApplicationWindow {
9595
// be slid up "under" the window.
9696
anchors.left: parent.left
9797
anchors.right: parent.right
98+
height: Constants.tabInfoBar.height
9899
z: 2
99100
tabName: sideNavBar.currentTabName
100101
subTabNames: mainTabs.subTabNames

0 commit comments

Comments
 (0)