Merge pull request #74804 from bnbarham/rename-equals

Update `StringRef::equals` references to `operator==`

Author: bnbarham

include/swift/AST/Attr.h

@@ -2875,7 +2875,7 @@ class DeclAttributes {
   /// Return whether this attribute set includes the given semantics attribute.
   bool hasSemanticsAttr(StringRef attrValue) const {
     return llvm::any_of(getSemanticsAttrs(), [&](const SemanticsAttr *attr) {
-      return attrValue.equals(attr->Value);
+      return attrValue == attr->Value;
     });
   }
 

include/swift/AST/Decl.h

@@ -6606,7 +6606,7 @@ class VarDecl : public AbstractStorageDecl {
   /// attribute.
   bool hasSemanticsAttr(StringRef attrValue) const {
     return llvm::any_of(getSemanticsAttrs(), [&](const SemanticsAttr *attr) {
-      return attrValue.equals(attr->Value);
+      return attrValue == attr->Value;
     });
   }
 

include/swift/AST/Identifier.h

@@ -96,7 +96,7 @@ class Identifier {
   bool nonempty() const { return !empty(); }
 
   LLVM_ATTRIBUTE_USED bool is(StringRef string) const {
-    return str().equals(string);
+    return str() == string;
   }
 
   /// isOperator - Return true if this identifier is an operator, false if it is

include/swift/Basic/JSONSerialization.h

@@ -355,10 +355,10 @@ inline bool isNumeric(llvm::StringRef S) {
   return false;
 }
 
-inline bool isNull(llvm::StringRef S) { return S.equals("null"); }
+inline bool isNull(llvm::StringRef S) { return S == "null"; }
 
 inline bool isBool(llvm::StringRef S) {
-  return S.equals("true") || S.equals("false");
+  return S == "true" || S == "false";
 }
 
 template<typename T>

include/swift/Frontend/InputFile.h

@@ -95,7 +95,7 @@ class InputFile final {
   /// llvm::MemoryBuffer::getFileOrSTDIN, which uses "<stdin>" instead of "-".
   static StringRef convertBufferNameFromLLVM_getFileOrSTDIN_toSwiftConventions(
       StringRef filename) {
-    return filename.equals("<stdin>") ? "-" : filename;
+    return filename == "<stdin>" ? "-" : filename;
   }
 
   /// Retrieves the name of the output file corresponding to this input.

include/swift/SIL/SILLocation.h

@@ -71,7 +71,7 @@ class SILLocation {
 
     inline bool operator==(const FilenameAndLocation &rhs) const {
       return line == rhs.line && column == rhs.column &&
-             filename.equals(rhs.filename);
+             filename == rhs.filename;
     }
 
     void dump() const;

include/swift/SILOptimizer/PassManager/PassPipeline.h

@@ -42,7 +42,7 @@ struct SILPassPipeline final {
 
   friend bool operator==(const SILPassPipeline &lhs,
                          const SILPassPipeline &rhs) {
-    return lhs.ID == rhs.ID && lhs.Name.equals(rhs.Name) &&
+    return lhs.ID == rhs.ID && lhs.Name == rhs.Name &&
            lhs.KindOffset == rhs.KindOffset;
   }
 

lib/ClangImporter/ImportDecl.cpp

@@ -5306,8 +5306,8 @@ namespace {
 
       // Add inferred attributes.
 #define INFERRED_ATTRIBUTES(ModuleName, ClassName, AttributeSet)               \
-  if (name.str().equals(#ClassName) &&                                         \
-      result->getParentModule()->getName().str().equals(#ModuleName)) {        \
+  if (name.str() == #ClassName &&                                              \
+      result->getParentModule()->getName().str() == #ModuleName) {             \
     using namespace inferred_attributes;                                       \
     addInferredAttributes(result, AttributeSet);                               \
   }

lib/Driver/DarwinToolChains.cpp

@@ -385,19 +385,19 @@ toolchains::Darwin::addArgsToLinkStdlib(ArgStringList &Arguments,
   if (context.Args.hasArg(options::OPT_runtime_compatibility_version)) {
     auto value = context.Args.getLastArgValue(
                                     options::OPT_runtime_compatibility_version);
-    if (value.equals("5.0")) {
+    if (value == "5.0") {
       runtimeCompatibilityVersion = llvm::VersionTuple(5, 0);
-    } else if (value.equals("5.1")) {
+    } else if (value == "5.1") {
       runtimeCompatibilityVersion = llvm::VersionTuple(5, 1);
-    } else if (value.equals("5.5")) {
+    } else if (value == "5.5") {
       runtimeCompatibilityVersion = llvm::VersionTuple(5, 5);
-    } else if (value.equals("5.6")) {
+    } else if (value == "5.6") {
       runtimeCompatibilityVersion = llvm::VersionTuple(5, 6);
-    } else if (value.equals("5.8")) {
+    } else if (value == "5.8") {
       runtimeCompatibilityVersion = llvm::VersionTuple(5, 8);
-    } else if (value.equals("6.0")) {
+    } else if (value == "6.0") {
       runtimeCompatibilityVersion = llvm::VersionTuple(6, 0);
-    } else if (value.equals("none")) {
+    } else if (value == "none") {
       runtimeCompatibilityVersion = std::nullopt;
     } else {
       // TODO: diagnose unknown runtime compatibility version?

lib/Driver/Driver.cpp

@@ -935,7 +935,7 @@ void Driver::buildInputs(const ToolChain &TC,
       file_types::ID Ty = file_types::TY_INVALID;
 
       // stdin must be handled specially.
-      if (Value.equals("-")) {
+      if (Value == "-") {
         // By default, treat stdin as Swift input.
         Ty = file_types::TY_Swift;
       } else {