Merge pull request #70 from homersimpsons/fix/prepare-statement-cache

Prepare Statement Cache issue

Author: moufmouf

src/Mouf/Database/MagicQuery.php

@@ -137,7 +137,7 @@ public function buildPreparedStatement(string $sql, array $parameters = []): str
             $sql = $this->getTwigEnvironment()->render($sql, $parameters);
         }
 
-        $availableParameterKeys = array_keys(array_filter($parameters, static function($param) { return $param !== null;}));
+        $availableParameterKeys = array_keys(array_filter($parameters, static function($param) { return $param !== null && $param !== [];}));
         // We choose md4 because it is fast.
         $cacheKey = 'request_build_'.hash('md4', get_class($this->platform).'__'.$sql.'__'.implode('_/_', $availableParameterKeys));
         $newSql = $this->cache->fetch($cacheKey);

tests/Mouf/Database/MagicQueryTest.php

@@ -475,4 +475,12 @@ public function testSetOutputDialect()
         $this->assertEquals('SELECT id FROM users', self::simplifySql($magicQuery->buildPreparedStatement($sql)));
 
     }
+
+    public function testPrepareStatementCache(): void
+    {
+        $magicQuery = new MagicQuery(null, new ArrayCache());
+
+        $this->assertEquals('SELECT * FROM users WHERE 0 <> 0', self::simplifySql($magicQuery->buildPreparedStatement('SELECT * FROM users WHERE id IN :users', ['users' => []])));
+        $this->assertEquals('SELECT * FROM users WHERE id IN (:users)', self::simplifySql($magicQuery->buildPreparedStatement('SELECT * FROM users WHERE id IN :users', ['users' => [1]])));
+    }
 }