`IO::Compress::Brotli` makefile error with static build

[vadimkantorov]

I have had to patch the Makefile like so:

perl Makefile.PL LINKTYPE=static
sed -i 's/$(CP) $(MYEXTLIB) "$@"/$(CP) $(MYEXTLIB) "$(dir $@)"/' Makefile                                                                 
make && make install

Otherwise this error happens:

2024-11-27T14:59:02.1061340Z cp brotli/libbrotlienc.a brotli/libbrotlidec.a brotli/libbrotlicommon.a "blib/arch/auto/IO/Compress/Brotli/Brotli.a"
2024-11-27T14:59:02.1073236Z cp: target 'blib/arch/auto/IO/Compress/Brotli/Brotli.a' is not a directory

(while using https://cpan.metacpan.org/authors/id/T/TI/TIMLEGGE/IO-Compress-Brotli-0.017.tar.gz)

Originally reported at:

• IO::Compress::Brotli makefile error with static build pmqs/IO-Compress#61

[timlegge]

What OS is this on? I am able to reproduce the issue on Ubuntu but the fix does not work here

[vadimkantorov]

Ubuntu 20.04 / with Alpine in docker

[vadimkantorov]

You can see the full repro here: https://github.com/busytex/busybiber/blob/main/.github/workflows/busybiber.yml

If you have evolved the Makefile generation since, maybe the fix needs to be adjusted too... but basically the line invoking cp needs to be fixed

[timlegge]

Hi Actually I misspoke - the build works but make test does not - did you happen to test? Tim Timothy Legge ***@***.*** ***@***.***

…

On Thu, Nov 28, 2024 at 6:02 AM Vadim Kantorov ***@***.***> wrote: Ubuntu 20.04 / with Alpine in docker — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH3N643H3IOAYJEGP536ST2C3S4XAVCNFSM6AAAAABSTC2TZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVG4YTMMBSGY> . You are receiving this because you commented.Message ID: ***@***.***>

[vadimkantorov]

No, I did not run the tests either :(

[timlegge]

Thanks. Definitely looks like a bug in ExtUtil::MakeMaker suite. I will try to track it down

…

On Thu, Nov 28, 2024, 10:09 a.m. Vadim Kantorov ***@***.***> wrote: No, I did not run the tests either :( — Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH3N675BQX6J4XLOW7NIHT2C4PZLAVCNFSM6AAAAABSTC2TZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBWGIYTCNZXGA> . You are receiving this because you commented.Message ID: ***@***.***>

[timlegge]

I have a working fix - just trying to sort out some minor warnings

[vadimkantorov]

Might be worth to add there a test with LINKTYPE=static... Or was it broken for both dynamic and static? If so, how could this problem not have been detected earlier?