fix: [#10] fix GitHub workflow infrastructure tests

- Update cloud-init syntax tests to handle template files (.tpl)
- Add ci-test-syntax target for CI environments with dummy SSH keys
- Fix template variable handling in test scripts
- Add custom yamllint config for CI (syntax-only validation)
- Simplify GitHub workflow to use consolidated test target
- Ensure all infrastructure validation works in CI environment

Author: josecelano

.github/workflows/infrastructure.yml

@@ -37,26 +37,14 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y yamllint
 
-      - name: Validate OpenTofu syntax
-        run: |
-          cd infrastructure/terraform
-          tofu init
-          tofu validate
-          tofu plan
-
-      - name: Validate cloud-init YAML
-        run: |
-          yamllint infrastructure/cloud-init/user-data.yaml
-          yamllint infrastructure/cloud-init/network-config.yaml
-
       - name: Test script permissions
         run: |
           test -x tests/infrastructure/test-local-setup.sh
           test -x tests/infrastructure/test-integration.sh
 
       - name: Run syntax tests
         run: |
-          make test-syntax
+          make ci-test-syntax
 
       - name: Validate Makefile targets
         run: |

.yamllint-ci.yml

@@ -0,0 +1,10 @@
+extends: default
+
+rules:
+  line-length: disable
+  comments: disable
+  document-start: disable
+  truthy: disable
+  trailing-spaces: disable
+  new-line-at-end-of-file: disable
+  indentation: disable

Makefile

@@ -260,4 +260,28 @@ vm-restart: ## Restart the VM
 	virsh start $(VM_NAME)
 	@echo "VM restarted"
 
-# Advanced targets
+# CI/CD specific targets
+ci-test-syntax: ## Test syntax for CI (with dummy values)
+	@echo "Testing syntax for CI environment..."
+	@echo "Creating temporary config with dummy values..."
+	@cd $(TERRAFORM_DIR) && \
+		echo 'ssh_public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQC dummy-key-for-ci-testing"' > ci-test.tfvars && \
+		tofu init && \
+		tofu validate && \
+		tofu plan -var-file=ci-test.tfvars && \
+		rm ci-test.tfvars
+	@echo "Testing cloud-init templates..."
+	@$(TESTS_DIR)/test-local-setup.sh syntax
+	@echo "Testing cloud-init YAML syntax with yamllint..."
+	@if command -v yamllint >/dev/null 2>&1; then \
+		yamllint -c .yamllint-ci.yml infrastructure/cloud-init/network-config.yaml && \
+		yamllint -c .yamllint-ci.yml infrastructure/cloud-init/meta-data.yaml && \
+		cd infrastructure/cloud-init && \
+		sed 's/$${ssh_public_key}/ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQC/' user-data.yaml.tpl > /tmp/user-data-test.yaml && \
+		sed 's/$${ssh_public_key}/ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQC/' user-data-minimal.yaml.tpl > /tmp/user-data-minimal-test.yaml && \
+		yamllint -c ../../.yamllint-ci.yml /tmp/user-data-test.yaml && \
+		yamllint -c ../../.yamllint-ci.yml /tmp/user-data-minimal-test.yaml && \
+		rm -f /tmp/user-data-test.yaml /tmp/user-data-minimal-test.yaml; \
+	else \
+		echo "yamllint not available, skipping additional YAML validation"; \
+	fi

tests/infrastructure/test-local-setup.sh

@@ -202,7 +202,8 @@ test_cloud_init_syntax() {
     local cloud_init_dir="${PROJECT_ROOT}/infrastructure/cloud-init"
 
     # Check if cloud-init files exist
-    for file in user-data.yaml meta-data.yaml network-config.yaml; do
+    local required_files=("user-data.yaml.tpl" "user-data-minimal.yaml.tpl" "meta-data.yaml" "network-config.yaml")
+    for file in "${required_files[@]}"; do
         if [ -f "${cloud_init_dir}/${file}" ]; then
             log_success "Found ${file}"
         else
@@ -213,13 +214,33 @@ test_cloud_init_syntax() {
 
     # Validate YAML syntax (if yamllint is available)
     if command -v yamllint >/dev/null 2>&1; then
-        for file in user-data.yaml network-config.yaml; do
+        # Test static YAML files
+        for file in meta-data.yaml network-config.yaml; do
             if yamllint "${cloud_init_dir}/${file}" >/dev/null 2>&1; then
                 log_success "${file} YAML syntax is valid"
             else
                 log_warning "${file} YAML syntax check failed (continuing anyway)"
             fi
         done
+
+        # Test template files by substituting variables
+        local temp_dir="/tmp/torrust-cloud-init-test"
+        mkdir -p "${temp_dir}"
+        
+        for template in user-data.yaml.tpl user-data-minimal.yaml.tpl; do
+            local test_file="${temp_dir}/${template%.tpl}"
+            # Substitute template variables with dummy values for syntax testing
+            sed 's/\${ssh_public_key}/ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQC/' "${cloud_init_dir}/${template}" > "${test_file}"
+            
+            if yamllint "${test_file}" >/dev/null 2>&1; then
+                log_success "${template} YAML syntax is valid (after variable substitution)"
+            else
+                log_warning "${template} YAML syntax check failed (continuing anyway)"
+            fi
+        done
+        
+        # Cleanup
+        rm -rf "${temp_dir}"
     else
         log_warning "yamllint not available, skipping YAML syntax validation"
     fi