From 2b032a28d2546372a910c73eccb703ba92cc4f3e Mon Sep 17 00:00:00 2001 From: Aiden Scandella Date: Mon, 16 Jan 2017 05:31:24 -0800 Subject: [PATCH] Improve instructions on fetching flamegraph scripts The first time I set this up on a new machine it pointed me to the repo, but didn't say which files I needed. So it took some trial and error before I got it working. We should be explicit in what we use. --- renderer/flamegraph.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/renderer/flamegraph.go b/renderer/flamegraph.go index 9a16d2e..6c9e957 100644 --- a/renderer/flamegraph.go +++ b/renderer/flamegraph.go @@ -30,7 +30,10 @@ import ( var errNoPerlScript = errors.New("Cannot find flamegraph scripts in the PATH or current " + "directory. You can download the script at https://github.com/brendangregg/FlameGraph. " + "These scripts should be added to your PATH or in the directory where go-torch is executed. " + - "Alternatively, you can run go-torch with the --raw flag.") + "Alternatively, you can run go-torch with the --raw flag." + + "Once installed you should have `stackcollapse.pl` and `flamegraph.pl`" + + "either with or without the `.pl` suffix, in your $PATH.", +) var ( stackCollapseScripts = []string{"stackcollapse.pl", "./stackcollapse.pl", "./FlameGraph/stackcollapse.pl"}