Fix Linux Compilation Errors

- Remove unnecessary copies in for loops

Author: jwindgassen

Source/Linter/Private/LintRule.cpp

@@ -109,7 +109,7 @@ TArray<TSharedPtr<FLintRuleViolation>> FLintRuleViolation::AllRuleViolationsWith
     // This should really be done when the structs are first created
     TArray<TSharedPtr<FLintRuleViolation>> SharedViolations;
     TArray<FLintRuleViolation> Violations = AllRuleViolationsWithViolator(RuleViolationCollection, SearchViolator);
-    for (const FLintRuleViolation Violation : Violations) {
+    for (const FLintRuleViolation& Violation : Violations) {
         SharedViolations.Push(MakeShared<FLintRuleViolation>(Violation));
     }
 

Source/Linter/Private/LintRuleSet.cpp

@@ -95,7 +95,7 @@ TArray<TSharedPtr<FLintRuleViolation>> ULintRuleSet::LintPathShared(const TArray
     TArray<FLintRuleViolation> RuleViolations = LintPath(AssetPaths, ParentScopedSlowTask);
 
     TArray<TSharedPtr<FLintRuleViolation>> SharedRuleViolations;
-    for (const FLintRuleViolation Violation : RuleViolations) {
+    for (const FLintRuleViolation& Violation : RuleViolations) {
         TSharedPtr<FLintRuleViolation> SharedViolation = MakeShared<FLintRuleViolation>(Violation);
         SharedViolation->PopulateAssetData();
         SharedRuleViolations.Push(SharedViolation);

Source/Linter/Private/TooltipTool/TooltipStringHelper.cpp

@@ -128,14 +128,14 @@ bool FTooltipStringHelper::ParseFunctionRawTooltip(FString RawTooltip, FText& Ou
 
 FString FTooltipStringHelper::ConvertTooltipDataToRawTooltip(FText FunctionDescription, TArray<TSharedPtr<FBPFunctionArgumentDescription>> Inputs, TArray<TSharedPtr<FBPFunctionArgumentDescription>> Outputs) {
     FString RawTooltip = FunctionDescription.ToString();
-    for (const TSharedPtr<FBPFunctionArgumentDescription> Arg : Inputs) {
+    for (const auto& Arg : Inputs) {
         RawTooltip.Append(FString::Printf(TEXT("\n@param %s  %s\t\t\t%s"), TEXT("     "), *Arg->ArgumentName.ToString(), *Arg->Tooltip.ToString()));
     }
 
     if (Outputs.Num() == 1) {
         RawTooltip.Append(FString::Printf(TEXT("\n@return       %s"), *Outputs[0]->Tooltip.ToString()));
     } else {
-        for (const TSharedPtr<FBPFunctionArgumentDescription> Arg : Outputs) {
+        for (const auto& Arg : Outputs) {
             RawTooltip.Append(FString::Printf(TEXT("\n@param %s  %s\t\t\t%s"), TEXT("[out]"), *Arg->ArgumentName.ToString(), *Arg->Tooltip.ToString()));
         }
     }

Source/Linter/Private/TooltipTool/TooltipTool.cpp

@@ -698,7 +698,7 @@ void STooltipTool::RebuildMemberList() {
     UBlueprint* Blueprint = Cast<UBlueprint>(BlueprintComboBox->GetSelectedItem().Get()->GetAsset());
 
     // Get variables
-    for (const FBPVariableDescription Member : Blueprint->NewVariables) {
+    for (const FBPVariableDescription& Member : Blueprint->NewVariables) {
         if ((Member.PropertyFlags & CPF_DisableEditOnInstance) != CPF_DisableEditOnInstance) {
             Members.Push(MakeShared<FBPVariableDescription>(Member));
         }

Source/Linter/Private/UI/LintReportAssetDetails.cpp

@@ -38,7 +38,7 @@ void SLintReportAssetDetails::Construct(const FArguments& Args) {
     int32 NumErrors = 0;
     int32 NumWarnings = 0;
 
-    for (const TSharedPtr<FLintRuleViolation> RuleViolation : RuleViolations.Get()) {
+    for (const auto& RuleViolation : RuleViolations.Get()) {
         switch (RuleViolation->ViolatedRule.Get()->GetDefaultObject<ULintRule>()->RuleSeverity) {
             case ELintRuleSeverity::Error: NumErrors++;
                 break;