CP-13861: Use a transaction when writing the guest agent xenstore keys

Signed-off-by: John Else <[email protected]>

Author: johnelse

xc/xenops_server_xen.ml

@@ -518,27 +518,28 @@ module HOST = struct
 			}) in
 		with_xs
 			(fun xs ->
-				xs.Xs.rm root;
-				let write_with_perms key value =
-					xs.Xs.write key value;
-					xs.Xs.setperms key perms
-				in
-				write_with_perms root "";
-				List.iter (fun feature ->
-					let feature_root = Filename.concat root feature.Host.name in
-					let parameters_root = Filename.concat feature_root "parameters" in
-					write_with_perms feature_root "";
-					write_with_perms parameters_root "";
-					write_with_perms
-						(Filename.concat feature_root "licensed")
-						(if feature.Host.licensed then "1" else "0");
-					List.iter
-						(fun (key, value) ->
-							write_with_perms
-								(Filename.concat parameters_root key)
-								value)
-						feature.Host.parameters)
-				features)
+				Xs.transaction xs (fun t ->
+					t.Xst.rm root;
+					let write_with_perms key value =
+						t.Xst.write key value;
+						t.Xst.setperms key perms
+					in
+					write_with_perms root "";
+					List.iter (fun feature ->
+						let feature_root = Filename.concat root feature.Host.name in
+						let parameters_root = Filename.concat feature_root "parameters" in
+						write_with_perms feature_root "";
+						write_with_perms parameters_root "";
+						write_with_perms
+							(Filename.concat feature_root "licensed")
+							(if feature.Host.licensed then "1" else "0");
+						List.iter
+							(fun (key, value) ->
+								write_with_perms
+									(Filename.concat parameters_root key)
+									value)
+							feature.Host.parameters)
+					features))
 end
 
 module VM = struct