PWN::Plugins::OwaspZAP module - #rubocop_fixes and code cleanup

Author: ninp0

README.md

@@ -37,7 +37,7 @@ $ rvm use ruby-3.2.2@pwn
 $ rvm list gemsets
 $ gem install --verbose pwn
 $ pwn
-pwn[v0.4.638]:001 >>> PWN.help
+pwn[v0.4.639]:001 >>> PWN.help
 ```
 
 [![Installing the pwn Security Automation Framework](https://raw.githubusercontent.com/0dayInc/pwn/master/documentation/pwn_install.png)](https://youtu.be/G7iLUY4FzsI)
@@ -52,7 +52,7 @@ $ rvm use ruby-3.2.2@pwn
 $ gem uninstall --all --executables pwn
 $ gem install --verbose pwn
 $ pwn
-pwn[v0.4.638]:001 >>> PWN.help
+pwn[v0.4.639]:001 >>> PWN.help
 ```
 
 

lib/pwn/plugins/owasp_zap.rb

@@ -113,14 +113,12 @@ module OwaspZap
           owasp_zap_cmd = "cd #{zap_dir} && ./#{zap_bin}"
         end
 
-        if opts[:proxy]
-          proxy = opts[:proxy].to_s.scrub.strip.chomp
-          proxy_uri = URI.parse(proxy)
-        else
-          random_port = PWN::Plugins::Sock.get_random_unused_port
-          proxy = "http://127.0.0.1:#{random_port}"
-          proxy_uri = URI.parse(proxy)
-        end
+        random_port = PWN::Plugins::Sock.get_random_unused_port
+
+        proxy = "http://127.0.0.1:#{random_port}"
+        proxy = opts[:proxy].to_s.scrub.strip.chomp if opts[:proxy]
+
+        proxy_uri = URI.parse(proxy)
         owasp_zap_cmd = "#{owasp_zap_cmd} -host #{proxy_uri.host} -port #{proxy_uri.port}"
         zap_obj[:host] = proxy_uri.host.to_s.scrub
         zap_obj[:port] = proxy_uri.port.to_i

lib/pwn/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PWN
-  VERSION = '0.4.638'
+  VERSION = '0.4.639'
 end