PWN::Plugins::Assembly module - rely upon archs native objdump bins to convert opcodes to asm within #opcodes_to_asm method

Author: ninp0

README.md

@@ -37,7 +37,7 @@ $ cd /opt/pwn
 $ ./install.sh
 $ ./install.sh ruby-gem
 $ pwn
-pwn[v0.5.30]:001 >>> PWN.help
+pwn[v0.5.31]:001 >>> PWN.help
 ```
 
 [![Installing the pwn Security Automation Framework](https://raw.githubusercontent.com/0dayInc/pwn/master/documentation/pwn_install.png)](https://youtu.be/G7iLUY4FzsI)
@@ -52,7 +52,7 @@ $ rvm use ruby-3.3.0@pwn
 $ gem uninstall --all --executables pwn
 $ gem install --verbose pwn
 $ pwn
-pwn[v0.5.30]:001 >>> PWN.help
+pwn[v0.5.31]:001 >>> PWN.help
 ```
 
 If you're using a multi-user install of RVM do:
@@ -62,7 +62,7 @@ $ rvm use ruby-3.3.0@pwn
 $ rvmsudo gem uninstall --all --executables pwn
 $ rvmsudo gem install --verbose pwn
 $ pwn
-pwn[v0.5.30]:001 >>> PWN.help
+pwn[v0.5.31]:001 >>> PWN.help
 ```
 
 PWN periodically upgrades to the latest version of Ruby which is reflected in `/opt/pwn/.ruby-version`.  The easiest way to upgrade to the latest version of Ruby from a previous PWN installation is to run the following script:

lib/pwn/plugins/assembly.rb

@@ -19,15 +19,15 @@ module Assembly
         arch = opts[:arch] ||= PWN::Plugins::DetectOS.arch
         endian = opts[:endian] ||= :little
 
+        raise "ERROR: opcodes parameter is required." if opcodes.nil?
+
         case arch
-        when 'i386', 'i686', 'x86'
-          arch_obj = Metasm::Ia32.new(endian)
-        when 'amd64', 'x86_64'
-          arch_obj = Metasm::X86_64.new(endian)
+        when 'amd64', 'i386', 'i686', 'x86', 'x86_64'
+          arch = 'i386'
         when 'armv4l', 'armv4b', 'armv5l', 'armv5b', 'armv6l', 'armv6b', 'armv7b', 'armv7l', 'arm', 'armhf'
-          arch_obj = Metasm::ARM.new(endian)
+          arch = 'arm'
         when 'aarch64', 'arm64'
-          arch_obj = Metasm::ARM64.new(endian)
+          arch = 'aarch64'
         else
           raise "Unsupported architecture: #{arch}"
         end
@@ -41,9 +41,14 @@ module Assembly
         # If opcodes appear to be '909090' then convert to "\x90\x90\x90"
         opcodes = opcodes.chars.each_slice(2).map(&:join).map { |x| format('\x%02x', x.to_i(16)) }.join if opcodes.length.even?
 
-        Metasm::Shellcode.disassemble(arch_obj, opcodes).to_s
+        pwn_asm_tmp = Tempfile.new('pwn_asm')
+        File.binwrite(pwn_asm_tmp.path, opcodes)
+        `objdump -D -b binary -m #{arch} -M intel --endian #{endian} #{pwn_asm_tmp.path}`
       rescue StandardError => e
         raise e
+      ensure
+        tmp_file = [pwn_asm_tmp.path]
+        FileUtils.rm_f(tmp_file) if File.exist?(pwn_asm_tmp.path)
       end
 
       # Supported Method Parameters::
@@ -58,6 +63,8 @@ module Assembly
         arch = opts[:arch] ||= PWN::Plugins::DetectOS.arch
         endian = opts[:endian] ||= :little
 
+        raise "ERROR: asm parameter is required." if asm.nil?
+
         case arch
         when 'i386', 'i686', 'x86'
           arch_obj = Metasm::Ia32.new(endian)
@@ -71,6 +78,8 @@ module Assembly
           raise "Unsupported architecture: #{arch}"
         end
 
+        raise "ERROR: #{as_bin} not found.  Choose a different arch parameter." unless File.exist?(as_bin)
+
         Metasm::Shellcode.assemble(arch_obj, asm).encode_string.bytes.map { |b| format('\x%02x', b) }.join
       rescue StandardError => e
         raise e

lib/pwn/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PWN
-  VERSION = '0.5.30'
+  VERSION = '0.5.31'
 end