Skip to content

Conversation

@evollu
Copy link
Contributor

@evollu evollu commented Jun 13, 2016

fix for issue #30

@alvaromb
Copy link
Collaborator

Hi @evollu and thanks for the PR!

What's the backward compatibility policy for this PR? Would this work under RN 0.26 and older?

@evollu
Copy link
Contributor Author

evollu commented Jun 13, 2016

It won't be compatible with older version. Is that required?

@wrousseau
Copy link

+1, it's a deprecation on react native. Here are the changes listed on react native changelog

// previously
const { DeviceEventEmitter } = require('react-native');
DeviceEventEmitter.addListener('keyboardWillShow', func);

// on 0.27.2 and newer
const { Keyboard } = require('react-native');
Keyboard.addListener('keyboardWillShow', func);

// 0.27.0 & 0.27.1
const Keyboard = require('Keyboard');
Keyboard.addListener('keyboardWillShow', func);

@alvaromb alvaromb added this to the 0.1.2 milestone Jun 15, 2016
@alvaromb
Copy link
Collaborator

Cool!

Can you update the README to reflect the compatibility @evollu? Something like

0.1.2 requires RN>=0.27.2

@evollu
Copy link
Contributor Author

evollu commented Jun 15, 2016

@alvaromb readme updated

@grabcode
Copy link

+1

@alvaromb alvaromb merged commit eb0c935 into APSL:master Jun 17, 2016
@alvaromb
Copy link
Collaborator

Merged! Will release today. Many thanks!

@alvaromb
Copy link
Collaborator

@ms88privat
Copy link

@alvaromb run into this today with RN 0.26. Could you please bump the Version Number in a Major style, e.g. v0.2.0? Other Apps will break...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants