Improve doxygen and unittest coverage for API

Mainly focusing on hardening the tests for return values.

Author: michalpasztamobica

UNITTESTS/features/netsocket/EthernetInterface/test_EthernetInterface.cpp

@@ -53,8 +53,6 @@ MBED_WEAK EMAC &EMAC::get_default_instance()
     return MockEMAC::get_instance();
 }
 
-
-
 OnboardNetworkStack &OnboardNetworkStack::get_default_instance()
 {
     return OnboardNetworkStackMock::get_instance();
@@ -119,6 +117,15 @@ class TestEthernetInterface: public testing::Test {
 TEST_F(TestEthernetInterface, constructor_default)
 {
     EXPECT_TRUE(iface);
+
+    // Test that this clas presents itself correctly
+    EXPECT_NE(nullptr, iface->ethInterface());
+    EXPECT_NE(nullptr, iface->emacInterface());
+
+    EXPECT_EQ(nullptr, iface->wifiInterface());
+    EXPECT_EQ(nullptr, iface->cellularBase());
+    EXPECT_EQ(nullptr, iface->cellularInterface());
+    EXPECT_EQ(nullptr, iface->meshInterface());
 }
 
 TEST_F(TestEthernetInterface, constructor_getter)
@@ -161,11 +168,15 @@ TEST_F(TestEthernetInterface, set_network)
     char ipAddress[NSAPI_IPv4_SIZE] = "127.0.0.1";
     char netmask[NSAPI_IPv4_SIZE] = "255.255.0.0";
     char gateway[NSAPI_IPv4_SIZE] = "127.0.0.2";
+    char macAddress[NSAPI_MAC_SIZE];
 
     const char *ipAddressArg;
     const char *netmaskArg;
     const char *gatewayArg;
 
+    // Before connecting return NULL
+    EXPECT_EQ(NULL, iface->get_mac_address());
+
     EXPECT_EQ(0, iface->get_ip_address());
     EXPECT_EQ(0, iface->get_netmask());
     EXPECT_EQ(0, iface->get_gateway());
@@ -194,6 +205,11 @@ TEST_F(TestEthernetInterface, set_network)
     EXPECT_TRUE(0 == strcmp(gateway, gatewayArg));
 
     // Testing the getters makes sense now.
+    EXPECT_CALL(*netStackIface, get_mac_address(_, _))
+    .Times(1)
+    .WillOnce(DoAll(SetArrayArgument<0>(macAddress, macAddress+NSAPI_MAC_SIZE), Return(macAddress)));
+    EXPECT_EQ(std::string(macAddress), std::string(iface->get_mac_address()));
+
     EXPECT_CALL(*netStackIface, get_ip_address(_, _))
     .Times(1)
     .WillOnce(DoAll(SetArgPointee<0>(*ipAddress), Return(ipAddress)));
@@ -230,6 +246,45 @@ TEST_F(TestEthernetInterface, attach)
     iface->attach(cb);
 }
 
+
+TEST_F(TestEthernetInterface, get_interface_name)
+{
+    char name[100] = "eth0";
+    EXPECT_EQ(NULL, iface->get_interface_name(name));
+
+    doConnect();
+
+    // The parameter will be an internal variable.
+    EXPECT_CALL(*netStackIface, get_interface_name(_))
+    .Times(1)
+    .WillOnce(Return(name));
+    EXPECT_EQ(std::string(name), std::string(iface->get_interface_name(name)));
+}
+
+TEST_F(TestEthernetInterface, get_ipv6_link_local_address)
+{
+    SocketAddress addr("4.3.2.1");
+    EXPECT_EQ(NSAPI_ERROR_NO_CONNECTION, iface->get_ipv6_link_local_address(&addr));
+    EXPECT_NE(std::string(addr.get_ip_address()), std::string("4.3.2.1"));
+    doConnect();
+
+    // The parameter will be an internal variable.
+    EXPECT_CALL(*netStackIface, get_ipv6_link_local_address(&addr))
+    .Times(1)
+    .WillOnce(Return(NSAPI_ERROR_OK));
+    EXPECT_EQ(NSAPI_ERROR_OK, iface->get_ipv6_link_local_address(&addr));
+}
+
+TEST_F(TestEthernetInterface, set_as_default)
+{
+    doConnect();
+
+    EXPECT_CALL(*stackMock, set_default_interface(netStackIface))
+    .Times(1);
+    iface->set_as_default();
+}
+
+
 TEST_F(TestEthernetInterface, set_dhcp)
 {
     EXPECT_EQ(NSAPI_ERROR_OK, iface->set_dhcp(false));

UNITTESTS/features/netsocket/NetworkInterface/test_NetworkInterface.cpp

@@ -148,6 +148,12 @@ TEST_F(TestNetworkInterface, set_blocking)
     EXPECT_EQ(iface->set_blocking(true), NSAPI_ERROR_UNSUPPORTED);
 }
 
+TEST_F(TestNetworkInterface, get_ipv6_link_local_address)
+{
+    SocketAddress a;
+    EXPECT_EQ(iface->get_ipv6_link_local_address(&a), NSAPI_ERROR_UNSUPPORTED);
+}
+
 void my_iface_callback(nsapi_event_t e, intptr_t i)
 {
     (void)e;