ONME-3113: Fix GCC_ARM and ARM compiler warnings from mbed-mesh-api

Warning #1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning

Warning #1-D: last line of file ends without a newline
- New line added at the end of file

Warning #997-D:
function "MeshInterfaceNanostack::initialize(NanostackPhy *)" is hidden
by "ThreadInterface::initialize"  -- virtual function override intended?
- virtual keyword removed from "MeshInterfaceNanostack::initialize"

Warning #1300-D: inherits implicit virtual
- Adding the virtual keyword in the derived class prevents the warning

Author: KariHaapalehto

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/LoWPANNDInterface.h

@@ -34,9 +34,9 @@ class LoWPANNDInterface : public MeshInterfaceNanostack {
     LoWPANNDInterface(NanostackRfPhy *phy) : MeshInterfaceNanostack(phy) { }
 
     nsapi_error_t initialize(NanostackRfPhy *phy);
-    int connect();
-    int disconnect();
-    bool getOwnIpAddress(char *address, int8_t len);
+    virtual int connect();
+    virtual int disconnect();
+    virtual bool getOwnIpAddress(char *address, int8_t len);
     bool getRouterIpAddress(char *address, int8_t len);
 private:
     mesh_error_t init();

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/MeshInterfaceNanostack.h

@@ -32,7 +32,7 @@ class MeshInterfaceNanostack : public MeshInterface {
      *
      *  @return     0 on success, negative on failure
      */
-    virtual nsapi_error_t initialize(NanostackPhy *phy);
+    nsapi_error_t initialize(NanostackPhy *phy);
 
     /** Start the interface
      *

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/NanostackEthernetInterface.h

@@ -27,9 +27,9 @@ class NanostackEthernetInterface : public MeshInterfaceNanostack {
     NanostackEthernetInterface(NanostackEthernetPhy *phy) : MeshInterfaceNanostack(phy) { }
 
     nsapi_error_t initialize(NanostackEthernetPhy *phy);
-    int connect();
-    int disconnect();
-    bool getOwnIpAddress(char *address, int8_t len);
+    virtual int connect();
+    virtual int disconnect();
+    virtual bool getOwnIpAddress(char *address, int8_t len);
     bool getRouterIpAddress(char *address, int8_t len);
 };
 

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/mbed-mesh-api/ThreadInterface.h

@@ -34,8 +34,8 @@ class ThreadInterface : public MeshInterfaceNanostack {
     ThreadInterface(NanostackRfPhy *phy) : MeshInterfaceNanostack(phy) { }
 
     nsapi_error_t initialize(NanostackRfPhy *phy);
-    int connect();
-    int disconnect();
+    virtual int connect();
+    virtual int disconnect();
 private:
     /*
      * \brief Initialization of the interface.
@@ -69,7 +69,7 @@ class ThreadInterface : public MeshInterfaceNanostack {
      * \param len is the length of the address buffer, must be at least 40 bytes
      * \return true if address is read successfully, false otherwise
      */
-    bool getOwnIpAddress(char *address, int8_t len);
+    virtual bool getOwnIpAddress(char *address, int8_t len);
 };
 
-#endif // THREADINTERFACE_H
+#endif // THREADINTERFACE_H

features/nanostack/FEATURE_NANOSTACK/mbed-mesh-api/source/include/enet_tasklet.h

@@ -32,4 +32,4 @@ int8_t enet_tasklet_get_ip_address(char *address, int8_t len);
 }
 #endif
 
-#endif // ENET_TASKLET_H
+#endif // ENET_TASKLET_H

features/nanostack/FEATURE_NANOSTACK/nanostack-interface/NanostackRfPhy.h

@@ -27,12 +27,12 @@ class NanostackRfPhy : public NanostackPhy {
      *  @return         Device driver ID or a negative error
      *                  code on failure
      */
-    int8_t phy_register() { return rf_register();}
+    virtual int8_t phy_register() { return rf_register();}
 
     /** Unregister this physical interface
      *
      */
-    void unregister() { rf_unregister(); }
+    virtual void unregister() { rf_unregister(); }
 };
 
 #endif /* NANOSTACK_RF_PHY_H_ */