Cellular: move RAT reading to better support ublox custom boards #11191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AT commands used in read_radio_technology() function are not supported by all boards so moving the function where it's actually used. Usage was already inside of the #ifdef's.
Member
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
Aug 9, 2019
0xc0170
approved these changes
Aug 9, 2019
Contributor
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Contributor
Author
|
Failed greentea test not related to this pr |
mirelachirica
approved these changes
Aug 12, 2019
Contributor
|
Waiting for pr merge fix from @ARMmbed/mbed-os-test |
Contributor
|
This is on top of 5.14 changes so now targeting that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AT commands used in read_radio_technology() function are not supported
by all boards so moving the function where it's actually used. Usage was
already inside of the #ifdef's.
Fixes the issue #11170
Pull request type
Reviewers