Fix cellular dns test with IAR compiled binary #11220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case printed IP address. If ip address is null, IAR compiled binary fails. Added check for printing null. If IP address is null, then it prints string 'null'.
jarvte
force-pushed
the
fix_cellular_dns_test
branch
from
84bb815 to
2ebc648
Compare
Member
kivaisan
approved these changes
Aug 14, 2019
AriParkkila
suggested changes
Aug 14, 2019
| // no IPV4 address, return | ||
| return NULL; | ||
| } | ||
| len = _at.read_string(_ip, NSAPI_IPv4_SIZE); |
| if (_stack_type != IPV4_STACK) { | ||
| if (len != -1 && _stack_type != IPV4_STACK) { | ||
| // in case stack type is not IPV4 only, try to look also for IPV6 address | ||
| (void)_at.read_string(_ip, PDP_IPV6_SIZE); |
Contributor
Author
There was a problem hiding this comment.
no, can't do that as this is an optional value
CellularContext now tries to get an IP address after connect and before sending NSAPI_STATUS_GLOBAL_UP. Even if we don't the IP address from the modem we will send NSAPI_STATUS_GLOBAL_UP and return success. Modem has an ip address but for some reason some modems don't give it to us.
jarvte
force-pushed
the
fix_cellular_dns_test
branch
from
2ebc648 to
6a17d74
Compare
jarvte
commented
Aug 14, 2019
| if (_stack_type != IPV4_STACK) { | ||
| if (len != -1 && _stack_type != IPV4_STACK) { | ||
| // in case stack type is not IPV4 only, try to look also for IPV6 address | ||
| (void)_at.read_string(_ip, PDP_IPV6_SIZE); |
Contributor
Author
There was a problem hiding this comment.
no, can't do that as this is an optional value
AriParkkila
approved these changes
Aug 14, 2019
kimlep01
approved these changes
Aug 14, 2019
Test case printed IP address. If ip address is null, IAR compiled binary fails. Added check for printing null. If IP address is null, then it prints string 'null'.
AnttiKauppila
approved these changes
Aug 21, 2019
0xc0170
approved these changes
Aug 21, 2019
Contributor
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Contributor
|
restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Contributor
|
Sitting on top of 5.14 changes so targeting for 5.14 now instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Binary compiled with IAR crashes when trying to print null string. Fixed to print 'null' when the dns test is trying to print an empty ip address.
Fixed also that there should not be an empty ip address after connect. After fix, still some modems don't give an ip address even they have it. This can't be fixed but network communication works properly.
Pull request type
Reviewers
@kivaisan @kimlep01