From 9e1765372375e79a5f2804bbebf15dff5c1c6ebe Mon Sep 17 00:00:00 2001 From: Lin Gao Date: Tue, 3 Dec 2019 13:28:02 -0600 Subject: [PATCH 1/5] Increase BUFF_SIZE to avoid error in AT response when debug is turned on --- features/cellular/framework/AT/ATHandler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/cellular/framework/AT/ATHandler.h b/features/cellular/framework/AT/ATHandler.h index 2ab937eb6ab..781304f04a2 100644 --- a/features/cellular/framework/AT/ATHandler.h +++ b/features/cellular/framework/AT/ATHandler.h @@ -48,7 +48,7 @@ class FileHandle; extern const char *OK; extern const char *CRLF; -#define BUFF_SIZE 32 +#define BUFF_SIZE 128 /* AT Error types enumeration */ enum DeviceErrorType { From a5a9683348f9b6fef5c9f9478a9e73c8e2e794dd Mon Sep 17 00:00:00 2001 From: Lin Gao Date: Tue, 3 Dec 2019 13:33:19 -0600 Subject: [PATCH 2/5] Change AT+COPS mode to manual first then fall back to auto to improve reliability. Fix a syntax error when RAT is set --- features/cellular/framework/AT/AT_CellularNetwork.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/cellular/framework/AT/AT_CellularNetwork.cpp b/features/cellular/framework/AT/AT_CellularNetwork.cpp index 161128ab0c4..2d704297744 100644 --- a/features/cellular/framework/AT/AT_CellularNetwork.cpp +++ b/features/cellular/framework/AT/AT_CellularNetwork.cpp @@ -222,7 +222,7 @@ nsapi_error_t AT_CellularNetwork::set_registration(const char *plmn) } else { tr_debug("Manual network registration to %s", plmn); if (_op_act != RAT_UNKNOWN) { - return _at.at_cmd_discard("+COPS", "=1,2,", "%s%d", plmn, _op_act); + return _at.at_cmd_discard("+COPS", "=4,2,", "%s%d", plmn, _op_act); } else { return _at.at_cmd_discard("+COPS", "=1,2,", "%s", plmn); } From d5d4520d62d413571e90080c5dbf31300a7410d9 Mon Sep 17 00:00:00 2001 From: Lin Gao Date: Tue, 3 Dec 2019 14:39:13 -0600 Subject: [PATCH 3/5] Implement set_access_technology_impl for Telit ME910 --- .../targets/TELIT/ME910/TELIT_ME910.cpp | 6 +++ .../targets/TELIT/ME910/TELIT_ME910.h | 2 + .../ME910/TELIT_ME910_CellularNetwork.cpp | 45 +++++++++++++++++++ .../TELIT/ME910/TELIT_ME910_CellularNetwork.h | 37 +++++++++++++++ 4 files changed, 90 insertions(+) create mode 100644 features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp create mode 100644 features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp index 9449a67eef8..59cbe3612dd 100644 --- a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp @@ -17,6 +17,7 @@ #include "TELIT_ME910.h" #include "TELIT_ME910_CellularContext.h" +#include "TELIT_ME910_CellularNetwork.h" #include "AT_CellularNetwork.h" #include "PinNames.h" #include "rtos/ThisThread.h" @@ -187,3 +188,8 @@ nsapi_error_t TELIT_ME910::soft_power_off() { return AT_CellularDevice::soft_power_off(); } + +AT_CellularNetwork *TELIT_ME910::open_network_impl(ATHandler &at) +{ + return new TELIT_ME910_CellularNetwork(at); +} diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.h b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.h index 6b0455d3fb6..9212b618e68 100644 --- a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.h +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.h @@ -48,6 +48,8 @@ class TELIT_ME910 : public AT_CellularDevice { virtual nsapi_error_t hard_power_off(); virtual nsapi_error_t soft_power_on(); virtual nsapi_error_t soft_power_off(); + virtual AT_CellularNetwork *open_network_impl(ATHandler &at); + private: bool _active_high; DigitalOut _pwr_key; diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp new file mode 100644 index 00000000000..adf998dd198 --- /dev/null +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp @@ -0,0 +1,45 @@ +/* + * Copyright (c) 2019, Arm Limited and affiliates. + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "TELIT_ME910_CellularNetwork.h" + +using namespace mbed; + +TELIT_ME910_CellularNetwork::TELIT_ME910_CellularNetwork(ATHandler &atHandler) : AT_CellularNetwork(atHandler) +{ +} + +TELIT_ME910_CellularNetwork::~TELIT_ME910_CellularNetwork() +{ +} + +nsapi_error_t TELIT_ME910_CellularNetwork::set_access_technology_impl(RadioAccessTechnology opsAct) +{ + switch (opsAct) { + case RAT_GSM: + case RAT_CATM1: + case RAT_NB1: + _op_act = opsAct; + return NSAPI_ERROR_OK; + + default: + _op_act = RAT_UNKNOWN; + return NSAPI_ERROR_UNSUPPORTED; + } +} + + diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h new file mode 100644 index 00000000000..439bf6137d4 --- /dev/null +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h @@ -0,0 +1,37 @@ +/* + * Copyright (c) 2019, Arm Limited and affiliates. + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef TELIT_ME910_CELLULAR_NETWORK_H_ +#define TELIT_ME910_CELLULAR_NETWORK_H_ + +#include "AT_CellularNetwork.h" + +namespace mbed { + +class TELIT_ME910_CellularNetwork : public AT_CellularNetwork { +public: + TELIT_ME910_CellularNetwork(ATHandler &atHandler); + virtual ~ TELIT_ME910_CellularNetwork(); + +protected: + virtual nsapi_error_t set_access_technology_impl(RadioAccessTechnology opRat); + +}; + +} // namespace mbed + +#endif // TELIT_ME910_CELLULAR_NETWORK_H_ From c8524c25be145ad6217197d4742a33ed477d5388 Mon Sep 17 00:00:00 2001 From: Lin Gao Date: Thu, 12 Dec 2019 15:14:24 -0600 Subject: [PATCH 4/5] add config option and property to choose automatic fallback for PLMN manual operator selection --- .../cellular/framework/API/CellularNetwork.h | 7 +++++ .../cellular/framework/AT/AT_CellularDevice.h | 31 ++++++++++--------- .../framework/AT/AT_CellularNetwork.cpp | 14 +++++++-- .../targets/QUECTEL/BC95/QUECTEL_BC95.cpp | 3 +- .../targets/QUECTEL/BG96/QUECTEL_BG96.cpp | 3 +- .../targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp | 3 +- .../targets/QUECTEL/M26/QUECTEL_M26.cpp | 1 + .../targets/QUECTEL/UG96/QUECTEL_UG96.cpp | 3 +- .../targets/RiotMicro/AT/RM1000_AT.cpp | 1 + .../targets/TELIT/HE910/TELIT_HE910.cpp | 3 +- .../targets/TELIT/ME910/TELIT_ME910.cpp | 3 +- .../ME910/TELIT_ME910_CellularNetwork.cpp | 2 +- .../TELIT/ME910/TELIT_ME910_CellularNetwork.h | 2 +- .../framework/targets/UBLOX/AT/UBLOX_AT.cpp | 1 + .../targets/UBLOX/N2XX/UBLOX_N2XX.cpp | 1 + .../framework/targets/UBLOX/PPP/UBLOX_PPP.cpp | 1 + features/cellular/mbed_lib.json | 4 +++ 17 files changed, 57 insertions(+), 26 deletions(-) diff --git a/features/cellular/framework/API/CellularNetwork.h b/features/cellular/framework/API/CellularNetwork.h index 947340746f6..16f3afeba5c 100644 --- a/features/cellular/framework/API/CellularNetwork.h +++ b/features/cellular/framework/API/CellularNetwork.h @@ -161,6 +161,13 @@ class CellularNetwork { NWModeManualAutomatic // if manual fails, fallback to automatic }; + /// Operator name format + enum OperatorNameFormat { + OperatorNameAlphaLong = 0, // alphanumeric long form + OperatorNameAlphaShort, // alphanumeric short form + OperatorNameNumeric // numeric digits + }; + /// Network registration information struct registration_params_t { RegistrationType _type; diff --git a/features/cellular/framework/AT/AT_CellularDevice.h b/features/cellular/framework/AT/AT_CellularDevice.h index 5c028a141bf..cb01686e4f4 100755 --- a/features/cellular/framework/AT/AT_CellularDevice.h +++ b/features/cellular/framework/AT/AT_CellularDevice.h @@ -42,21 +42,22 @@ class AT_CellularDevice : public CellularDevice { * to the end (just before PROPERTY_MAX). Do not modify any of the existing fields. */ enum CellularProperty { - PROPERTY_C_EREG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. - PROPERTY_C_GREG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. - PROPERTY_C_REG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. - PROPERTY_AT_CGSN_WITH_TYPE, // 0 = not supported, 1 = supported. AT+CGSN without type is likely always supported similar to AT+GSN. - PROPERTY_AT_CGDATA, // 0 = not supported, 1 = supported. Alternative is to support only ATD*99***# - PROPERTY_AT_CGAUTH, // 0 = not supported, 1 = supported. APN authentication AT commands supported - PROPERTY_AT_CNMI, // 0 = not supported, 1 = supported. New message (SMS) indication AT command - PROPERTY_AT_CSMP, // 0 = not supported, 1 = supported. Set text mode AT command - PROPERTY_AT_CMGF, // 0 = not supported, 1 = supported. Set preferred message format AT command - PROPERTY_AT_CSDH, // 0 = not supported, 1 = supported. Show text mode AT command - PROPERTY_IPV4_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV4? - PROPERTY_IPV6_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV6? - PROPERTY_IPV4V6_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV4 and IPV6 simultaneously? - PROPERTY_NON_IP_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support Non-IP? - PROPERTY_AT_CGEREP, // 0 = not supported, 1 = supported. Does modem support AT command AT+CGEREP. + PROPERTY_C_EREG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. + PROPERTY_C_GREG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. + PROPERTY_C_REG, // AT_CellularNetwork::RegistrationMode. What support modem has for this registration type. + PROPERTY_AT_CGSN_WITH_TYPE, // 0 = not supported, 1 = supported. AT+CGSN without type is likely always supported similar to AT+GSN. + PROPERTY_AT_CGDATA, // 0 = not supported, 1 = supported. Alternative is to support only ATD*99***# + PROPERTY_AT_CGAUTH, // 0 = not supported, 1 = supported. APN authentication AT commands supported + PROPERTY_AT_CNMI, // 0 = not supported, 1 = supported. New message (SMS) indication AT command + PROPERTY_AT_CSMP, // 0 = not supported, 1 = supported. Set text mode AT command + PROPERTY_AT_CMGF, // 0 = not supported, 1 = supported. Set preferred message format AT command + PROPERTY_AT_CSDH, // 0 = not supported, 1 = supported. Show text mode AT command + PROPERTY_IPV4_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV4? + PROPERTY_IPV6_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV6? + PROPERTY_IPV4V6_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support IPV4 and IPV6 simultaneously? + PROPERTY_NON_IP_PDP_TYPE, // 0 = not supported, 1 = supported. Does modem support Non-IP? + PROPERTY_AT_CGEREP, // 0 = not supported, 1 = supported. Does modem support AT command AT+CGEREP. + PROPERTY_AT_COPS_FALLBACK_AUTO, // 0 = not supported, 1 = supported. Does modem support mode 4 of AT+COPS= ? PROPERTY_MAX }; diff --git a/features/cellular/framework/AT/AT_CellularNetwork.cpp b/features/cellular/framework/AT/AT_CellularNetwork.cpp index 2d704297744..39bb607edad 100644 --- a/features/cellular/framework/AT/AT_CellularNetwork.cpp +++ b/features/cellular/framework/AT/AT_CellularNetwork.cpp @@ -209,9 +209,10 @@ nsapi_error_t AT_CellularNetwork::get_network_registering_mode(NWRegisteringMode nsapi_error_t AT_CellularNetwork::set_registration(const char *plmn) { + NWRegisteringMode mode = NWModeAutomatic; + if (!plmn) { tr_debug("Automatic network registration"); - NWRegisteringMode mode; if (get_network_registering_mode(mode) != NSAPI_ERROR_OK) { return NSAPI_ERROR_DEVICE_ERROR; } @@ -221,10 +222,17 @@ nsapi_error_t AT_CellularNetwork::set_registration(const char *plmn) return NSAPI_ERROR_OK; } else { tr_debug("Manual network registration to %s", plmn); + mode = NWModeManual; + OperatorNameFormat format = OperatorNameNumeric; +#ifdef MBED_CONF_CELLULAR_PLMN_FALLBACK_AUTO + if (_device.get_property(AT_CellularDevice::PROPERTY_AT_COPS_FALLBACK_AUTO)) { + mode = NWModeManualAutomatic; + } +#endif if (_op_act != RAT_UNKNOWN) { - return _at.at_cmd_discard("+COPS", "=4,2,", "%s%d", plmn, _op_act); + return _at.at_cmd_discard("+COPS", "=", "%d%d%s%d", mode, format, plmn, _op_act); } else { - return _at.at_cmd_discard("+COPS", "=1,2,", "%s", plmn); + return _at.at_cmd_discard("+COPS", "=", "%d%d%s", mode, format, plmn); } } } diff --git a/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp b/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp index 7661d1821e5..3023bfd4c75 100644 --- a/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp +++ b/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp @@ -43,7 +43,8 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV6_STACK 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE - 0, // PROPERTY_AT_CGEREP + 0, // PROPERTY_AT_CGEREP, + 0, // PROPERTY_AT_COPS_FALLBACK_AUTO }; QUECTEL_BC95::QUECTEL_BC95(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp index 3a5de952dac..754a9b03e68 100644 --- a/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp +++ b/features/cellular/framework/targets/QUECTEL/BG96/QUECTEL_BG96.cpp @@ -60,7 +60,8 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV6_STACK 0, // PROPERTY_IPV4V6_STACK 1, // PROPERTY_NON_IP_PDP_TYPE - 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_CGEREP, + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; QUECTEL_BG96::QUECTEL_BG96(FileHandle *fh, PinName pwr, bool active_high, PinName rst) diff --git a/features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp b/features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp index 502d4ca509f..b33d41fe3d8 100644 --- a/features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp +++ b/features/cellular/framework/targets/QUECTEL/EC2X/QUECTEL_EC2X.cpp @@ -61,7 +61,8 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV6_STACK 1, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE - 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_CGEREP, + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; QUECTEL_EC2X::QUECTEL_EC2X(FileHandle *fh, PinName pwr, bool active_high, PinName rst) diff --git a/features/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26.cpp b/features/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26.cpp index d5637c269ef..72ae0c74766 100644 --- a/features/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26.cpp +++ b/features/cellular/framework/targets/QUECTEL/M26/QUECTEL_M26.cpp @@ -40,6 +40,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; QUECTEL_M26::QUECTEL_M26(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96.cpp b/features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96.cpp index a2b52f4ecc7..ae41f5e737d 100644 --- a/features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96.cpp +++ b/features/cellular/framework/targets/QUECTEL/UG96/QUECTEL_UG96.cpp @@ -42,7 +42,8 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV6_STACK 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE - 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_CGEREP, + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; QUECTEL_UG96::QUECTEL_UG96(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/RiotMicro/AT/RM1000_AT.cpp b/features/cellular/framework/targets/RiotMicro/AT/RM1000_AT.cpp index 2d13cc828e9..32545d6ff4d 100644 --- a/features/cellular/framework/targets/RiotMicro/AT/RM1000_AT.cpp +++ b/features/cellular/framework/targets/RiotMicro/AT/RM1000_AT.cpp @@ -44,6 +44,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 0, // PROPERTY_AT_CGEREP + 0, // PROPERTY_AT_COPS_FALLBACK_AUTO }; RM1000_AT::RM1000_AT(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/TELIT/HE910/TELIT_HE910.cpp b/features/cellular/framework/targets/TELIT/HE910/TELIT_HE910.cpp index dc32dac0604..7f312b9976a 100644 --- a/features/cellular/framework/targets/TELIT/HE910/TELIT_HE910.cpp +++ b/features/cellular/framework/targets/TELIT/HE910/TELIT_HE910.cpp @@ -36,7 +36,8 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV6_STACK 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE - 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_CGEREP, + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; TELIT_HE910::TELIT_HE910(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp index 59cbe3612dd..385f25b4bfa 100644 --- a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910.cpp @@ -58,6 +58,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; //the delay between sending AT commands @@ -191,5 +192,5 @@ nsapi_error_t TELIT_ME910::soft_power_off() AT_CellularNetwork *TELIT_ME910::open_network_impl(ATHandler &at) { - return new TELIT_ME910_CellularNetwork(at); + return new TELIT_ME910_CellularNetwork(at, *this); } diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp index adf998dd198..7a00290a26f 100644 --- a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.cpp @@ -19,7 +19,7 @@ using namespace mbed; -TELIT_ME910_CellularNetwork::TELIT_ME910_CellularNetwork(ATHandler &atHandler) : AT_CellularNetwork(atHandler) +TELIT_ME910_CellularNetwork::TELIT_ME910_CellularNetwork(ATHandler &atHandler, AT_CellularDevice &device) : AT_CellularNetwork(atHandler, device) { } diff --git a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h index 439bf6137d4..1087183c6a5 100644 --- a/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h +++ b/features/cellular/framework/targets/TELIT/ME910/TELIT_ME910_CellularNetwork.h @@ -24,7 +24,7 @@ namespace mbed { class TELIT_ME910_CellularNetwork : public AT_CellularNetwork { public: - TELIT_ME910_CellularNetwork(ATHandler &atHandler); + TELIT_ME910_CellularNetwork(ATHandler &atHandler, AT_CellularDevice &device); virtual ~ TELIT_ME910_CellularNetwork(); protected: diff --git a/features/cellular/framework/targets/UBLOX/AT/UBLOX_AT.cpp b/features/cellular/framework/targets/UBLOX/AT/UBLOX_AT.cpp index b424c28d1f0..dbf92e02b0c 100644 --- a/features/cellular/framework/targets/UBLOX/AT/UBLOX_AT.cpp +++ b/features/cellular/framework/targets/UBLOX/AT/UBLOX_AT.cpp @@ -37,6 +37,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; #elif defined(UBX_MDM_SARA_U2XX) || defined(UBX_MDM_SARA_G3XX) static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { diff --git a/features/cellular/framework/targets/UBLOX/N2XX/UBLOX_N2XX.cpp b/features/cellular/framework/targets/UBLOX/N2XX/UBLOX_N2XX.cpp index dcf832641fa..27e69d93654 100644 --- a/features/cellular/framework/targets/UBLOX/N2XX/UBLOX_N2XX.cpp +++ b/features/cellular/framework/targets/UBLOX/N2XX/UBLOX_N2XX.cpp @@ -34,6 +34,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV4_STACK 0, // PROPERTY_IPV6_STACK 0, // PROPERTY_IPV4V6_STACK + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; UBLOX_N2XX::UBLOX_N2XX(FileHandle *fh): AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.cpp b/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.cpp index f2a2396d707..13126eac208 100644 --- a/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.cpp +++ b/features/cellular/framework/targets/UBLOX/PPP/UBLOX_PPP.cpp @@ -38,6 +38,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; #elif defined(UBX_MDM_SARA_U2XX) || defined(UBX_MDM_SARA_G3XX) static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { diff --git a/features/cellular/mbed_lib.json b/features/cellular/mbed_lib.json index 9e653189536..074404ab4f9 100644 --- a/features/cellular/mbed_lib.json +++ b/features/cellular/mbed_lib.json @@ -36,6 +36,10 @@ "max-cp-data-recv-len" : { "help": "Max length of the buffer storing data received over control plane", "value": 1358 + }, + "plmn-fallback-auto" : { + "help": "If manual PLMN is selected, use mode 4 manual/automatic in AT+COPS to try automatic mode if manual selection fails. Set to null to disable", + "value": null } } } From 0bc8f4f726be014e4fe5bb27b10fcb84d28a465e Mon Sep 17 00:00:00 2001 From: Lin Gao Date: Thu, 19 Dec 2019 13:45:30 -0600 Subject: [PATCH 5/5] Revert BUFF_SIZE fix, to be fixed in another PR. Add missing property entries --- features/cellular/framework/AT/ATHandler.h | 2 +- .../framework/targets/GENERIC/GENERIC_AT3GPP/GENERIC_AT3GPP.cpp | 1 + .../framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/features/cellular/framework/AT/ATHandler.h b/features/cellular/framework/AT/ATHandler.h index 781304f04a2..2ab937eb6ab 100644 --- a/features/cellular/framework/AT/ATHandler.h +++ b/features/cellular/framework/AT/ATHandler.h @@ -48,7 +48,7 @@ class FileHandle; extern const char *OK; extern const char *CRLF; -#define BUFF_SIZE 128 +#define BUFF_SIZE 32 /* AT Error types enumeration */ enum DeviceErrorType { diff --git a/features/cellular/framework/targets/GENERIC/GENERIC_AT3GPP/GENERIC_AT3GPP.cpp b/features/cellular/framework/targets/GENERIC/GENERIC_AT3GPP/GENERIC_AT3GPP.cpp index 15df309b2f7..cacfac6b870 100644 --- a/features/cellular/framework/targets/GENERIC/GENERIC_AT3GPP/GENERIC_AT3GPP.cpp +++ b/features/cellular/framework/targets/GENERIC/GENERIC_AT3GPP/GENERIC_AT3GPP.cpp @@ -37,6 +37,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 1, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; GENERIC_AT3GPP::GENERIC_AT3GPP(FileHandle *fh) : AT_CellularDevice(fh) diff --git a/features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp b/features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp index ad1b1082b93..a3e094b0eca 100644 --- a/features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp +++ b/features/cellular/framework/targets/MultiTech/DragonflyNano/PPP/SARA4_PPP.cpp @@ -37,6 +37,7 @@ static const intptr_t cellular_properties[AT_CellularDevice::PROPERTY_MAX] = { 0, // PROPERTY_IPV4V6_STACK 0, // PROPERTY_NON_IP_PDP_TYPE 1, // PROPERTY_AT_CGEREP + 1, // PROPERTY_AT_COPS_FALLBACK_AUTO }; SARA4_PPP::SARA4_PPP(FileHandle *fh) : AT_CellularDevice(fh)