Skip to content

Conversation

@newellf
Copy link
Contributor

@newellf newellf commented Sep 17, 2024

Description

Bugfix. For GRCh38, temporary matepair files names separated reference name from file ending with an underscore, but scaffold contigs in GRCh38 also have an underscore, so mate pairs were incorrectly matched. Changed file name to include "xxx"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added unit tests and ran qsv for previously failing sample

Are WDL Updates Required?

sv.wdl will need to be updated to a new release of adamajava to include this change.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Fix file naming of matepair file tmp files from _ to _xxx_ due to chrUn_ scaffold contigs in GRCh38
Committing test file that was not included in previous commit.
@newellf newellf merged commit 36cef08 into master Sep 17, 2024
@newellf newellf deleted the qsv_matefile branch September 17, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants