Skip to content

Conversation

@holmeso
Copy link
Contributor

@holmeso holmeso commented Oct 1, 2024

Description

Remove unnecessary check on quality (if in standard mode), adjust getBaseName method as the inputs that are passed to it have had the pertinent parts (/1, /2) removed

Fixes # (issue)

Type of change

Performance

How Has This Been Tested?

Additional unit tests, and has been run against real life fastqs

Are WDL Updates Required?

No, although this change will most benefit the FTUB_WGGSS workflow.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@holmeso holmeso merged commit 0a26d1d into master Oct 1, 2024
1 check passed
@holmeso holmeso deleted the qmule_ftub branch October 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants