-
-
Notifications
You must be signed in to change notification settings - Fork 10
Community App Store (Sourcery refactored) #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
448e3de to
ad10e86
Compare
| For the full list of settings and their values, see | ||
| https://docs.djangoproject.com/en/dev/ref/settings/ | ||
| """ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 123-384 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| @@ -1,4 +1,5 @@ | |||
| """ Settings required by django-app. """ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 32-32 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
conreq/utils/environment.py
Outdated
| ENV_PREFIX = os.environ.get("CONREQ_ENV_PREFIX", "").rstrip("_").upper() | ||
| if ENV_PREFIX: | ||
| ENV_PREFIX = ENV_PREFIX + "_" | ||
| ENV_PREFIX = f'{ENV_PREFIX}_' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 16-16 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
conreq/utils/environment.py
Outdated
| base_url = base_url + "/" | ||
| if prepend_slash: | ||
| base_url = "/" + base_url | ||
| base_url = f'/{base_url}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_base_url refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
conreq/utils/environment.py
Outdated
| home_url = home_url + "/" | ||
| if prepend_slash: | ||
| home_url = "/" + home_url | ||
| home_url = f'/{home_url}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_home_url refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
conreq/utils/views.py
Outdated
| params = self.request.GET.copy() | ||
| params["success"] = True | ||
| self.success_url = self.request.path + f"?{params.urlencode()}" | ||
| self.success_url = f'{self.request.path}?{params.urlencode()}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function SuccessCurrentUrlMixin.get_success_url refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
conreq/utils/views.py
Outdated
| """Placeholder view function intended for debugging or development.""" | ||
| return HttpResponse( | ||
| __name__ + ": This is a stub for a view that has not yet been defined." | ||
| f'{__name__}: This is a stub for a view that has not yet been defined.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function stub refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
for more information, see https://pre-commit.ci
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #69 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
app_storebranch, then run:Help us improve this pull request!