Add test case for when password or user contains special characters

Author: jonathan-s

dbbackup/db/postgresql.py

@@ -1,5 +1,7 @@
-from dbbackup import utils
+from urllib.parse import quote
 import logging
+
+from dbbackup import utils
 from .base import BaseCommandDBConnector
 from .exceptions import DumpError
 
@@ -12,9 +14,9 @@ def create_postgres_uri(self):
         raise DumpError('A host name is required')
 
     dbname = self.settings.get('NAME') or ''
-    user = self.settings.get('USER') or ''
+    user = quote(self.settings.get('USER') or '')
     password = self.settings.get('PASSWORD') or ''
-    password = ':{}'.format(password) if password else ''
+    password = ':{}'.format(quote(password)) if password else ''
     if not user:
         password = ''
     else:

dbbackup/tests/settings.py

@@ -6,7 +6,7 @@
 import sys
 from dotenv import load_dotenv
 
-test = len(sys.argv) < 0 or sys.argv[1] == 'test'
+test = len(sys.argv) <= 1 or sys.argv[1] == 'test'
 if not test:
     load_dotenv()
 

dbbackup/tests/test_connectors/test_postgresql.py

@@ -21,6 +21,14 @@ def setUp(self):
         self.connector.settings['NAME'] = 'dbname'
         self.connector.settings['HOST'] = 'hostname'
 
+    def test_user_password_uses_special_characters(self, mock_dump_cmd):
+        self.connector.settings['PASSWORD'] = '@!'
+        self.connector.settings['USER'] = '@'
+
+        self.connector.create_dump()
+
+        self.assertIn('postgresql://%40:%40%21@hostname/dbname', mock_dump_cmd.call_args[0][0])
+
     def test_create_dump(self, mock_dump_cmd):
         dump = self.connector.create_dump()
         # Test dump