Skip to content

fix(model): fix conflicting $setOnInsert default values with update values in bulkWrite #9160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2020
Merged

fix(model): fix conflicting $setOnInsert default values with update values in bulkWrite #9160

merged 3 commits into from
Jun 22, 2020

Conversation

@AbdelrahmanHafez
Copy link
Collaborator

fixes #9157

@AbdelrahmanHafez AbdelrahmanHafez changed the title test: repro #9157 fix(model): fix conflicting $setOnInsert default values with update values in bulkWrite Jun 21, 2020
@vkarpov15 vkarpov15 added this to the 5.9.20 milestone Jun 22, 2020
vkarpov15
vkarpov15 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 8a8ff91 into Automattic:master Jun 22, 2020
@AbdelrahmanHafez
Copy link
Collaborator Author

Happy to help 👍

@AbdelrahmanHafez AbdelrahmanHafez deleted the gh-9157 branch June 22, 2020 21:30
This was referenced Mar 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.9.20

Development

Successfully merging this pull request may close these issues.

BulkWrite with setDefaultsOnInsert:true throws error

2 participants

@AbdelrahmanHafez @vkarpov15