Refactoring #8
Open
Refactoring #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for autonomy-station ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for goofy-archimedes-7da566 failed.
|
pldespaigne
approved these changes
Aug 22, 2022
Comment on lines
+65
to
+69
| const validAddress = /^0x[a-fA-F0-9]{40}$/.test(value); | ||
| if (!validAddress) { | ||
| setState(s => ({ ...s, contract: { ...s.contract, name: '', abi: undefined }, error: <>Invalid address!</> })); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
It might be useful to have this extracted into an helper function, so we could re-use that elsewhere 🤷
Contributor
|
LGTM, need to finish testing then I will approve. Just next time split this updates a bit more in either more commits or more PR's please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.