Skip to content

Handle eventhub cardinality #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2019
Merged

Handle eventhub cardinality #527

merged 3 commits into from
Sep 4, 2019

Conversation

@maiqbal11
Copy link
Contributor

@maiqbal11 maiqbal11 commented Aug 21, 2019

Fixes #411

@maiqbal11 maiqbal11 mentioned this pull request Aug 21, 2019
Merged
@pragnagopa
Copy link
Member

pragnagopa commented Aug 21, 2019

Can you please send a separate PR for updating proto file?

@maiqbal11 maiqbal11 mentioned this pull request Aug 21, 2019
Merged
@maiqbal11 maiqbal11 force-pushed the handle-eventhub-cardinality branch from e78fd17 to 20fb4f5 Compare August 22, 2019 17:49
@maiqbal11
Copy link
Contributor Author

maiqbal11 commented Aug 22, 2019

@pragnagopa, rebased on top of the new dev after updating protobuf.

pragnagopa
pragnagopa reviewed Aug 24, 2019
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes needed in the worker or library to convert TypedDataCollection to a list of events? Can you please point me code where this conversion happens?

tests/endtoend/eventhub_batch_functions/eventhub_multiple/function.json
"name": "events",
"direction": "in",
"cardinality": "many",
"dataType": "string",
Copy link
Member

@pragnagopa pragnagopa Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not specify dataType. String is default

Copy link
Contributor Author

@maiqbal11 maiqbal11 Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are failing on a JSON deserialization step when dataType is not specified as string. The SDK must be assuming that we are writing a JSON deserializable string by default. I was able to repro in Node. Will open an issue against the SDK.

Copy link
Contributor Author

@maiqbal11 maiqbal11 Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue on the EventHub extension: Azure/azure-functions-eventhubs-extension#17.

@maiqbal11
Copy link
Contributor Author

maiqbal11 commented Sep 3, 2019

no changes needed in the worker or library to convert TypedDataCollection to a list of events? Can you please point me code where this conversion happens?

Here is the corresponding library code: Azure/azure-functions-python-library#24

pragnagopa
pragnagopa approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maiqbal11 maiqbal11 merged commit 0217fe4 into dev Sep 4, 2019
@maiqbal11 maiqbal11 deleted the handle-eventhub-cardinality branch September 4, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pragnagopa pragnagopa pragnagopa approved these changes

@Hazhzeng Hazhzeng Awaiting requested review from Hazhzeng

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to receive events batch in Eventhub triggered function

3 participants

@maiqbal11 @pragnagopa