Fixed VM and VMSS Tests, Added SessionRecords, and updated VMSS Update Logic/Strategy Pass Ins

Author: ookoka

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.cs

@@ -479,5 +479,12 @@ public void TestProxyAgentSetting()
         {
             TestRunner.RunTestScript("Test-ProxyAgentSetting");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestVMSSAddProxyAgentExtension()
+        {
+            TestRunner.RunTestScript("Test-VMSSAddProxyAgentExtension");
+        }
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1

@@ -5965,4 +5965,54 @@ function Test-ProxyAgentSetting
         # Cleanup
         Clean-ResourceGroup $rgname;
     }
+}
+
+<#
+.SYNOPSIS
+Test-VMSSAddProxyAgentExtension creates a VMSS with Enabled ProxyAgent and added ProxyAgentExtension
+#>
+function Test-VMSSAddProxyAgentExtension
+{
+    # Setup
+    $rgname = Get-ComputeTestResourceName;
+    $loc = "eastus2";
+
+    
+    try
+    {
+        # Common
+        New-AzResourceGroup -Name $rgname -Location $loc -Force;
+
+        $vmssName = 'vmss' + $rgname;
+        $domainNameLabel1 = "d1" + $rgname;
+        
+        $adminUsername = Get-ComputeTestResourceName;
+        $password = Get-PasswordForVM;
+        $adminPassword = $password | ConvertTo-SecureString -AsPlainText -Force;
+        $cred = New-Object System.Management.Automation.PSCredential ($adminUsername, $adminPassword);
+        $linuxImage = "Canonical:0001-com-ubuntu-server-jammy:22_04-lts:latest"
+
+        # Case 1: Create using simple parameter set
+        $vmss = New-AzVmss -ResourceGroupName $rgname -Location $loc -Credential $cred -VMScaleSetName $vmssName -DomainNameLabel $domainNameLabel1 -Image $linuxImage -EnableProxyAgent -AddProxyAgentExtension
+
+        # verify
+        Assert-AreEqual $vmss.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.Enabled $true
+
+
+        # Update vmss to add proxy agent extension 
+        $VMSS = Get-AzVmss -ResourceGroupName $rgname -VMScaleSetName $vmssName
+        $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $true
+        $vmssUpdated = Update-AzVmss -ResourceGroupName $rgname -Name $vmssName -VirtualMachineScaleSet $VMSS
+
+        
+
+        # Validate 
+        Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.Enabled $true
+        Assert-AreEqual $vmssUpdated.VirtualMachineProfile.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $true
+    }
+    finally
+    {
+        # Cleanup
+        Clean-ResourceGroup $rgname;
+    }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs

@@ -696,12 +696,5 @@ public void TestVMAddProxyAgentExtension()
         {
             TestRunner.RunTestScript("Test-VMAddProxyAgentExtension");
         }
-
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestVMSSAddProxyAgentExtension()
-        {
-            TestRunner.RunTestScript("Test-VMSSAddProxyAgentExtension");
-        }
     }
 }

src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1

@@ -7974,38 +7974,3 @@ function Test-VMAddProxyAgentExtension
         Clean-ResourceGroup $resourceGroupName;
     }
 }
-
-<#
-.SYNOPSIS
-Test-VMSSAddProxyAgentExtension creates a VMSS with Enabled ProxyAgent and added ProxyAgentExtension
-#>
-function Test-VMSSAddProxyAgentExtension
-{
-    # Setup
-    $resourceGroupName = Get-ComputeTestResourceName;
-    $adminUsername = Get-ComputeTestResourceName;
-    $adminPassword = Get-PasswordForVM | ConvertTo-SecureString -AsPlainText -Force;
-    $cred = New-Object System.Management.Automation.PSCredential ($adminUsername, $adminPassword);
-    $vmssName = 'VMSS1';
-    $imageName = "Canonical:0001-com-ubuntu-server-jammy:22_04-lts:latest";
-
-    
-    try
-    {
-        New-AzVmss -ResourceGroupName $resourceGroupName -VMScaleSetName $vmssName -Credential $cred -image $imageName -Location 'eastus2' -EnableProxyAgent -AddProxyAgentExtension
-
-        # Update vmss to add proxy agent extension 
-        $VMSS = Get-AzVmss -ResourceGroupName $resourceGroupName -VMScaleSetName $vmssName
-        $VMSS = Set-AzVmssProxyAgentSetting -VirtualMachineScaleSet $VMSS -EnableProxyAgent $true -AddProxyAgentExtension $true
-        Update-AzVmss -ResourceGroupName $resourceGroupName -Name $vmssName -VirtualMachineScaleSet $VMSS 
-
-        # Validate 
-        Assert-AreEqual $VMSS.SecurityProfile.ProxyAgentSettings.Enabled $true
-        Assert-AreEqual $VMSS.SecurityProfile.ProxyAgentSettings.AddProxyAgentExtension $true
-    }
-    finally
-    {
-        # Cleanup
-        Clean-ResourceGroup $resourceGroupName;
-    }
-}