Merge pull request #5 from Azure/network-september

Merging source repo

Author: ejdelrio

.azure-pipelines/util/analyze-steps.yml

@@ -15,14 +15,14 @@ steps:
   inputs:
     command: custom
     custom: msbuild
-    arguments: 'build.proj /t:GenerateHelp /p:Configuration=${{ parameters.configuration }}'
+    arguments: 'build.proj /t:GenerateHelp /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
 
 - task: DotNetCoreCLI@2
   displayName: 'Static Analysis'
   inputs:
     command: custom
     custom: msbuild
-    arguments: 'build.proj /t:StaticAnalysis /p:Configuration=${{ parameters.configuration }}'
+    arguments: 'build.proj /t:StaticAnalysis /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
 
 - template: publish-artifacts-steps.yml
   parameters:

.azure-pipelines/util/build-steps.yml

@@ -9,7 +9,7 @@ steps:
   inputs:
     command: custom
     custom: msbuild
-    arguments: 'build.proj /t:Build /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }}'
+    arguments: 'build.proj /t:Build /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
 
 - template: publish-artifacts-steps.yml
   parameters:

.azure-pipelines/util/test-steps.yml

@@ -14,7 +14,7 @@ steps:
   inputs:
     command: custom
     custom: msbuild
-    arguments: 'build.proj /t:${{ parameters.testTarget }} /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }}'
+    arguments: 'build.proj /t:${{ parameters.testTarget }} /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
 
 - template: publish-artifacts-steps.yml
   parameters:

.azure-pipelines/windows-powershell.yml

@@ -19,6 +19,36 @@ jobs:
       testFramework: ${{ variables.TestFramework }}
       configuration: ${{ variables.Configuration }}
 
+- job: Analyze
+  displayName: Analyze
+  dependsOn: Build
+  condition: succeeded()
+  pool:
+    vmImage: ${{ variables.WindowsImage }}
+
+  steps:
+  - template: util/analyze-steps.yml
+    parameters:
+      osName: ${{ variables.WindowsName }}
+      configuration: ${{ variables.Configuration }}
+  - task: PowerShell@2
+    displayName: 'Cleanup Build'
+    inputs:
+      targetType: filePath
+      filePath: tools/CleanupBuild.ps1
+      pwsh: true
+  - task: NuGetCommand@2
+    displayName: 'Download BinSkim'
+    inputs:
+      command: custom
+      arguments: 'install Microsoft.CodeAnalysis.BinSkim -OutputDirectory $(System.DefaultWorkingDirectory)/tools/SecurityTools'
+  - task: PowerShell@2
+    displayName: 'Run BinSkim'
+    inputs:
+      targetType: filePath
+      filePath: tools/SecurityTools/RunBinSkim.ps1
+      pwsh: true
+
 - job: Test
   displayName: Test
   dependsOn: Build

.github/ISSUE_TEMPLATE/az-module-bug-report.md

@@ -37,7 +37,7 @@ assignees: ''
 
 ## Module versions
 
-<!-- Please run (Get-Module -Name Az.* -ListAvailable) and paste the output in the below code block -->
+<!-- Please run (Get-Module  -ListAvailable) and paste the output in the below code block -->
 
 ```powershell
 
@@ -53,7 +53,7 @@ assignees: ''
 
 ## Error output
 
-<!-- Please run Resolve-AzureRmError and paste the output in the below code block -->
+<!-- Please run Resolve-AzError and paste the output in the below code block -->
 
 ```
 

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,7 @@
 name: Feature request
 about: Suggest a new feature or improvement
 title: ''
-labels: Feature Request
+labels: Azure PS Team, Feature Request
 assignees: ''
 
 ---

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,11 +6,13 @@
 
 ## Checklist
 
-- [ ] I have read the [_Submitting Changes_](https://github.com/Azure/azure-powershell/blob/master/CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](https://github.com/Azure/azure-powershell/blob/master/CONTRIBUTING.md)
+- [ ] I have read the [_Submitting Changes_](../CONTRIBUTING.md#submitting-changes) section of [`CONTRIBUTING.md`](../CONTRIBUTING.md)
 - [ ] The title of the PR is clear and informative
-- [ ] The appropriate [change log has been updated](https://github.com/Azure/azure-powershell/blob/master/CONTRIBUTING.md#updating-the-change-log)
-- [ ] The PR does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/master/documentation/breaking-changes/breaking-changes-definition.md)
+- [ ] The appropriate `ChangeLog.md` file(s) has been updated:
+    - For any service, the `ChangeLog.md` file can be found at `src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md`
+    - A snippet outlining the change(s) made in the PR should be written under the `## Upcoming Release` header -- no new version header should be added
+- [ ] The PR does not introduce [breaking changes](../documentation/breaking-changes/breaking-changes-definition.md)
 - [ ] If applicable, the changes made in the PR have proper test coverage
 - [ ] For public API changes to cmdlets:
-    - [ ] the changes have gone through a [cmdlet design review](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (Microsoft internal partners only)
-    - [ ] the cmdlet markdown files were [generated using the `platyPS` module](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/help-generation.md)
+    - [ ] a cmdlet design review was approved for the changes in [this repository](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (_Microsoft internal only_)
+    - [ ] the markdown help files have been regenerated using the commands listed [here](../documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)

.gitignore

@@ -222,9 +222,8 @@ Package
 launchSettings.json
 /src/StackAdmin/AzureRM/AzureRM.psm1
 /src/StackAdmin/AzureStack/AzureStack.psm1
+/CsprojMappings.json
 /ModuleMappings.json
-/SolutionMappings.json
-/TestMappings.json
 /tools/Modules/tmp
 /tools/Az/Az.psm1
 /Azure.PowerShell.sln

.travis.yml

@@ -65,12 +65,14 @@ The following is a list of guidelines that pull requests opened in the Azure Pow
 The following guidelines must be followed in **EVERY** pull request that is opened.
 
 - Title of the pull request is clear and informative
-- The appropriate `ChangeLog.md` file has been updated with a snippet describing the changes being made
+- The appropriate `ChangeLog.md` file(s) has been updated:
+    - For any service, the `ChangeLog.md` file can be found at `src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md`
+    - A snippet outlining the change(s) made in the PR should be written under the `## Upcoming Release` header -- no new version header should be added
 - There are a [small number of commits](documentation/development-docs/cleaning-up-commits.md) that each have an informative message
 - All files shipped with a module should contain a proper Microsoft license header
 - For public API changes to cmdlets:
-    - a cmdlet design review was approved for the changes in [this repository](https://github.com/Azure/azure-powershell-cmdlet-review-pr)
-    - the markdown help files have been regenerated using the commands listed [here](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)
+    - a cmdlet design review was approved for the changes in [this repository](https://github.com/Azure/azure-powershell-cmdlet-review-pr) (_Microsoft internal only_)
+    - the markdown help files have been regenerated using the commands listed [here](documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module)
 
 #### Testing guidelines