re-recorded all test cases

Author: hiaga

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Backupcenter/Search-AzDataProtectionBackupInstanceInAzGraph.ps1

@@ -7,7 +7,7 @@
     param (
         [Parameter(Mandatory, HelpMessage='Subscription of Vault')]
         [System.String[]]
-        ${Subscription},
+        ${Subscription}, # TODO: add alias to all ARG command params
 
         [Parameter(Mandatory=$false, HelpMessage='Resource Group of Vault')]
         [System.String[]]

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Backupcenter/Search-AzDataProtectionBackupVaultInAzGraph.ps1

@@ -8,7 +8,7 @@
         [Parameter(Mandatory, HelpMessage='Subscription of Vault')]
         [Alias('SubscriptionId')]
         [System.String[]]
-        ${Subscription}, # TODO: add alias to all ARG command params
+        ${Subscription},
 
         [Parameter(Mandatory=$false, HelpMessage='Resource Group of Vault')]
         [Alias('ResourceGroupName')]

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Restore/Initialize-AzDataProtectionRestoreRequest.ps1

@@ -89,7 +89,7 @@
         [System.String]
         ${TargetContainerURI},
 
-        [Parameter(ParameterSetName="RestoreAsFiles", Mandatory, HelpMessage='File name to be prefixed to the restored backup data.')]
+        [Parameter(ParameterSetName="RestoreAsFiles", Mandatory=$false, HelpMessage='File name to be prefixed to the restored backup data.')]
         [System.String]
         ${FileNamePrefix},
 
@@ -192,12 +192,26 @@
            $restoreRequest.RestoreTargetInfo = [Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Models.Api20231201.RestoreFilesTargetInfo]::new()
            $restoreRequest.RestoreTargetInfo.ObjectType = "RestoreFilesTargetInfo"
 
-           if(!($PSBoundParameters.ContainsKey("FileNamePrefix")) -or !($PSBoundParameters.ContainsKey("TargetContainerURI")) ){
-                $errormsg = "FileNamePrefix and TargetContainerURI parameters are required for RestoreAsFiles "
-    			    throw $errormsg
+           if($manifest.fileNamePrefixDisabled -and $PSBoundParameters.ContainsKey("FileNamePrefix")){
+               $errormsg = "FileNamePrefix can't be set for given DatasourceType. Please try again after removing FileNamePrefix parameter"
+    		   throw $errormsg
+           }
+           elseif($manifest.fileNamePrefixDisabled -and !($PSBoundParameters.ContainsKey("TargetContainerURI"))){
+               $errormsg = "TargetContainerURI parameter is required for RestoreAsFiles for given DatasourceType"
+    		   throw $errormsg
+           }
+           elseif( !$manifest.fileNamePrefixDisabled -and (!($PSBoundParameters.ContainsKey("FileNamePrefix")) -or !($PSBoundParameters.ContainsKey("TargetContainerURI"))) ){
+                $errormsg = "FileNamePrefix and TargetContainerURI parameters are required for RestoreAsFiles for given DatasourceType"
+    		    throw $errormsg
            }
 
-           $restoreRequest.RestoreTargetInfo.TargetDetail.FilePrefix = $FileNamePrefix
+           if($manifest.fileNamePrefixDisabled){
+               $restoreRequest.RestoreTargetInfo.TargetDetail.FilePrefix = "dummyprefix"
+           }
+           else{
+               $restoreRequest.RestoreTargetInfo.TargetDetail.FilePrefix = $FileNamePrefix
+           }
+           
            $restoreRequest.RestoreTargetInfo.TargetDetail.RestoreTargetLocationType = "AzureBlobs"
            $restoreRequest.RestoreTargetInfo.TargetDetail.Url = $TargetContainerURI
 

src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Platform/Vault/Set-AzDataProtectionMSIPermission.ps1

@@ -213,30 +213,17 @@
                       $storageAccountSubId = ($targetResourceArmId -split "/resourceGroups/")[0]
                   }
                   else{
-                      if($StorageAccountARMId -eq ""){#$StorageAccountResourceGroupName -eq $null){
+                      if($StorageAccountARMId -eq ""){
                           $err = "Permissions can't be assigned to target storage account. Please input parameter StorageAccountARMId"
                           throw $err
                       }
 
                       # storage Account subscription and resource group
-                      $storageAccountSubId = ($StorageAccountARMId -split "/resourceGroups/")[0] # "/subscriptions/" + $subscriptionIdInternal
-                      $storageAccResourceGroupId = ($StorageAccountARMId -split "/providers/")[0] #$storageAccountSubId + "/resourceGroups/" + $StorageAccountResourceGroupName
-                      
-                      # $url = $restoreRequest.RestoreTargetInfo.TargetDetail.Url
-                      # 
-                      # if(-not ($url -match "^https://.+blob.core.windows.net/.+")){
-                      #     $err = "Parameter restoreRequest.RestoreTargetInfo.TargetDetail.Url is not in correct format"
-                      #     throw $err
-                      # }
-                      # $storageAccName = (($url -split "//")[1] -split "\.")[0]
-                      # 
-                      # CheckStorageModuleDependency
-                      # $contextSub = (Get-AzContext).Subscription.Id
-                      # Set-AzContext -SubscriptionId $subscriptionIdInternal | Out-Null
+                      $storageAccountSubId = ($StorageAccountARMId -split "/resourceGroups/")[0]
+                      $storageAccResourceGroupId = ($StorageAccountARMId -split "/providers/")[0]
 
                       # storage Account ID
-                      $storageAccId = $StorageAccountARMId #(Get-AzStorageAccount -ResourceGroupName $StorageAccountResourceGroupName -Name $storageAccName).Id
-                      # Set-AzContext -SubscriptionId $contextSub | Out-Null
+                      $storageAccId = $StorageAccountARMId                      
                   }
 
                   $CheckPermission = $AllRoles | Where-Object { ($_.Scope -eq $storageAccId -or $_.Scope -eq $storageAccResourceGroupId -or  $_.Scope -eq $storageAccountSubId) -and $_.RoleDefinitionName -eq $Permission}

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureBlob.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "PointInTimeBased", "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "OriginalLocation", "AlternateLocation" ],
   "itemLevelRecoveyEnabled": true,
+  "fileNamePrefixDisabled": false,
   "addBackupDatasourceParametersList": true,
   "backupConfigurationRequired": false,
   "addDataStoreParametersList": false,

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureDatabaseForMySQL.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "RestoreAsFiles" ],
   "itemLevelRecoveyEnabled": false,
+  "fileNamePrefixDisabled": true,
   "addBackupDatasourceParametersList": false,
   "backupConfigurationRequired": false,
   "addDataStoreParametersList": false,
@@ -28,7 +29,7 @@
     "disableAddRetentionRule": false,
     "disableCustomRetentionTag": false,
     "backupScheduleSupported": true,
-    "supportedBackupFrequency": [ "Weekly", "Monthly" ],
+    "supportedBackupFrequency": [ "Weekly" ],
     "defaultPolicy": {
       "name": "MySQLPolicy1",
       "datasourceTypes": [ "Microsoft.DBforMySQL/flexibleServers" ],

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureDatabaseForPGFlexServer.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "RestoreAsFiles" ],
   "itemLevelRecoveyEnabled": false,
+  "fileNamePrefixDisabled":  true,
   "addBackupDatasourceParametersList": false,
   "backupConfigurationRequired": false,
   "addDataStoreParametersList": false,
@@ -28,7 +29,7 @@
     "disableAddRetentionRule": false,
     "disableCustomRetentionTag": false,
     "backupScheduleSupported": true,
-    "supportedBackupFrequency": [ "Weekly", "Monthly" ],
+    "supportedBackupFrequency": [ "Daily", "Weekly" ],
     "defaultPolicy": {
       "name": "PGFlexPolicy1",
       "datasourceTypes": [ "Microsoft.DBforPostgreSQL/flexibleServers" ],

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureDatabaseForPostgreSQL.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "AlternateLocation", "RestoreAsFiles" ],
   "itemLevelRecoveyEnabled": false,
+  "fileNamePrefixDisabled": false,
   "addBackupDatasourceParametersList": false,
   "backupConfigurationRequired": false,
   "addDataStoreParametersList": false,

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureDisk.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "AlternateLocation" ],
   "itemLevelRecoveyEnabled": false,
+  "fileNamePrefixDisabled": false,
   "addBackupDatasourceParametersList": false,
   "backupConfigurationRequired": false,
   "addDataStoreParametersList": true,

src/DataProtection/DataProtection.Autorest/custom/manifests/AzureKubernetesService.json

@@ -15,6 +15,7 @@
   "allowedRestoreModes": [ "RecoveryPointBased" ],
   "allowedRestoreTargetTypes": [ "AlternateLocation", "OriginalLocation" ],
   "itemLevelRecoveyEnabled": true,
+  "fileNamePrefixDisabled": false,
   "addBackupDatasourceParametersList": true,
   "backupConfigurationRequired": true,
   "addDataStoreParametersList": true,