[Storage] Removed StorageFileDataSmbShareOwner from value set of DefaultSharePermission (#15190)

Author: blueww

src/Storage/Storage.Management.Test/ScenarioTests/StorageAccountTests.ps1

@@ -998,21 +998,21 @@ function Test-NewSetAzStorageAccountFileAADDS
         Assert-AreEqual 'AADDS' $sto.AzureFilesIdentityBasedAuth.DirectoryServiceOptions; 
         Assert-AreEqual 'StorageFileDataSmbShareContributor' $sto.AzureFilesIdentityBasedAuth.DefaultSharePermission; 		
 
-		$sto = Set-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -EnableAzureActiveDirectoryDomainServicesForFile $false -DefaultSharePermission StorageFileDataSmbShareOwner
+		$sto = Set-AzStorageAccount -ResourceGroupName $rgname -Name $stoname -EnableAzureActiveDirectoryDomainServicesForFile $false -DefaultSharePermission StorageFileDataSmbShareReader
         Assert-AreEqual $stoname $sto.StorageAccountName;
         Assert-AreEqual $stotype $sto.Sku.Name;
         Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
         Assert-AreEqual $kind $sto.Kind; 
         Assert-AreEqual 'None' $sto.AzureFilesIdentityBasedAuth.DirectoryServiceOptions; 
-        Assert-AreEqual 'StorageFileDataSmbShareOwner' $sto.AzureFilesIdentityBasedAuth.DefaultSharePermission; 
+        Assert-AreEqual 'StorageFileDataSmbShareReader' $sto.AzureFilesIdentityBasedAuth.DefaultSharePermission; 
 
         $sto = Get-AzStorageAccount -ResourceGroupName $rgname  -Name $stoname;
         Assert-AreEqual $stoname $sto.StorageAccountName;
         Assert-AreEqual $stotype $sto.Sku.Name;
         Assert-AreEqual $loc.ToLower().Replace(" ", "") $sto.Location;
         Assert-AreEqual $kind $sto.Kind; 
         Assert-AreEqual 'None' $sto.AzureFilesIdentityBasedAuth.DirectoryServiceOptions; 
-        Assert-AreEqual 'StorageFileDataSmbShareOwner' $sto.AzureFilesIdentityBasedAuth.DefaultSharePermission; 
+        Assert-AreEqual 'StorageFileDataSmbShareReader' $sto.AzureFilesIdentityBasedAuth.DefaultSharePermission; 
 
         Retry-IfException { Remove-AzureRmStorageAccount -Force -ResourceGroupName $rgname -Name $stoname; }
     }

src/Storage/Storage.Management.Test/SessionRecords/Microsoft.Azure.Commands.Management.Storage.Test.ScenarioTests.StorageAccountTests/TestNewSetAzStorageAccountFileAADDS.json

@@ -24,6 +24,9 @@
 * Supported enable Smb Multichannel on File service
     -  `Update-AzStorageFileServiceProperty`
 * Fixed copy inside same account issue by access source with anonymous credential, when copy Blob inside same account with Oauth credential
+* Removed StorageFileDataSmbShareOwner from value set of parameter DefaultSharePermission in create/udpate storage account
+    - `New-AzStorageAccount`
+    - `Set-AzStorageAccount`
 
 ## Version 3.7.0
 * Supported file share snapshot

src/Storage/Storage.Management/ChangeLog.md

@@ -467,7 +467,6 @@ public bool AllowCrossTenantReplication
             DefaultSharePermissionType.StorageFileDataSmbShareContributor,
             DefaultSharePermissionType.StorageFileDataSmbShareReader,
             DefaultSharePermissionType.StorageFileDataSmbShareElevatedContributor,
-            DefaultSharePermissionType.StorageFileDataSmbShareOwner,
             IgnoreCase = true)]
         public string DefaultSharePermission { get; set; }
 

src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs

@@ -448,7 +448,6 @@ public bool AllowCrossTenantReplication
             DefaultSharePermissionType.StorageFileDataSmbShareContributor,
             DefaultSharePermissionType.StorageFileDataSmbShareReader,
             DefaultSharePermissionType.StorageFileDataSmbShareElevatedContributor,
-            DefaultSharePermissionType.StorageFileDataSmbShareOwner,
             IgnoreCase = true)]
         public string DefaultSharePermission { get; set; }
 

src/Storage/Storage.Management/StorageAccount/SetAzureStorageAccount.cs

@@ -467,7 +467,7 @@ Default share permission for users using Kerberos authentication if RBAC role is
 Type: System.String
 Parameter Sets: (All)
 Aliases:
-Accepted values: None, StorageFileDataSmbShareContributor, StorageFileDataSmbShareReader, StorageFileDataSmbShareElevatedContributor, StorageFileDataSmbShareOwner
+Accepted values: None, StorageFileDataSmbShareContributor, StorageFileDataSmbShareReader, StorageFileDataSmbShareElevatedContributor
 
 Required: False
 Position: Named

src/Storage/Storage.Management/help/New-AzStorageAccount.md

@@ -541,7 +541,7 @@ Default share permission for users using Kerberos authentication if RBAC role is
 Type: System.String
 Parameter Sets: (All)
 Aliases:
-Accepted values: None, StorageFileDataSmbShareContributor, StorageFileDataSmbShareReader, StorageFileDataSmbShareElevatedContributor, StorageFileDataSmbShareOwner
+Accepted values: None, StorageFileDataSmbShareContributor, StorageFileDataSmbShareReader, StorageFileDataSmbShareElevatedContributor
 
 Required: False
 Position: Named

src/Storage/Storage.Management/help/Set-AzStorageAccount.md

@@ -10,3 +10,5 @@
 "Az.Storage","Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet.SetAzureStorageFileContent","Set-AzStorageFileContent","0","1050","The parameter set 'Share' for cmdlet 'Set-AzStorageFileContent' has been removed.","Add parameter set 'Share' back to cmdlet 'Set-AzStorageFileContent'."
 "Az.Storage","Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet.SetAzureStorageFileContent","Set-AzStorageFileContent","0","1050","The parameter set 'Directory' for cmdlet 'Set-AzStorageFileContent' has been removed.","Add parameter set 'Directory' back to cmdlet 'Set-AzStorageFileContent'."
 "Az.Storage","Microsoft.WindowsAzure.Commands.Storage.File.Cmdlet.SetAzureStorageFileContent","Set-AzStorageFileContent","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Set-AzStorageFileContent' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Set-AzStorageFileContent'."
+"Az.Storage","Microsoft.Azure.Commands.Management.Storage.NewAzureStorageAccountCommand","New-AzStorageAccount","0","2040","The validation set for parameter 'DefaultSharePermission' for cmdlet 'New-AzStorageAccount' no longer contains the value 'StorageFileDataSmbShareOwner'.","Add 'StorageFileDataSmbShareOwner' back to the validation set for 'DefaultSharePermission'."
+"Az.Storage","Microsoft.Azure.Commands.Management.Storage.SetAzureStorageAccountCommand","Set-AzStorageAccount","0","2040","The validation set for parameter 'DefaultSharePermission' for cmdlet 'Set-AzStorageAccount' no longer contains the value 'StorageFileDataSmbShareOwner'.","Add 'StorageFileDataSmbShareOwner' back to the validation set for 'DefaultSharePermission'."