Skip to content

Conversation

@greenms
Copy link
Contributor

@greenms greenms commented Nov 13, 2020

Description

New PowerShell cmdlets for new Azure service

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@greenms greenms changed the title Generation for RedisEnterpriseCache Add generated cmdlets for new RedisEnterpriseCache service Nov 13, 2020
@greenms
Copy link
Contributor Author

greenms commented Nov 13, 2020

What do I have to update for ChangeLog.md? My service does not have a src/{{SERVICE}}/{{SERVICE}}/ path, so where would the ChangeLog.md file go?

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some examples are not provided
  • Please record your tests for mock tests run in CI pipeline
    .\test-module.ps1 -Record

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required

@greenms
Copy link
Contributor Author

greenms commented Dec 1, 2020

@dolauli Do all CredScan checks have to pass? Or can CredScan checks fail if they are false positives?

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests are skipped. Is that expected?

@greenms
Copy link
Contributor Author

greenms commented Dec 4, 2020

Some of the tests are skipped. Is that expected?

@dolauli Yes, there are some cmdlets that are not yet fully supported, so these wouldn't return expected output at this time. Two of these partially supported cmdlets require using a valid storage key which we wouldn't want in the repo. There are a few other cmdlets that could still be tested. I will create tests for those soon and push them. Thanks.

@dolauli dolauli merged commit de96d33 into Azure:generation Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants