From 5fa66f978ba2206ec886da14da545e2c2790acff Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Fri, 3 Feb 2023 11:17:23 +0530 Subject: [PATCH 1/7] {AzureDataShare} fixes Azure/azure-powershell#20822 fix the description fixes Azure/azure-powershell#20822 fix the description The StorageAccountResourceId parameter in the "New-AzDataShareDataSetMapping" PowerShell cmdlet is used to specify the resource ID of the Azure storage account that is the source of the data being shared. This parameter is required when creating a new data set mapping for an Azure Data Share and is used to identify the storage account from which the data will be shared. The resource ID of the storage account can be obtained from the Azure portal or through Azure PowerShell. The AccountName parameter in the "New-AzDataShareDataSetMapping" PowerShell cmdlet is used to specify the name of the Azure storage account that is the source of the data being shared. This parameter is required when creating a new data set mapping for an Azure Data Share and is used to identify the storage account from which the data will be shared. The account name of the storage account must be unique within Azure and can be used to access the storage account and the data stored within it. The ResourceGroup parameter in the "New-AzDataShareDataSetMapping" PowerShell cmdlet is used to specify the name of the Azure resource group that contains the Azure storage account being shared. This parameter is required when creating a new data set mapping for an Azure Data Share and is used to identify the resource group that holds the storage account from which the data will be shared. The resource group can be used to manage the resources within it, such as the storage account and the data set mapping. --- src/DataShare/DataShare/help/New-AzDataShareDataSetMapping.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataShare/DataShare/help/New-AzDataShareDataSetMapping.md b/src/DataShare/DataShare/help/New-AzDataShareDataSetMapping.md index bd29a3fed506..508b316cd8e4 100644 --- a/src/DataShare/DataShare/help/New-AzDataShareDataSetMapping.md +++ b/src/DataShare/DataShare/help/New-AzDataShareDataSetMapping.md @@ -60,7 +60,7 @@ This command creates a data set mapping AdsDataSetMapping to storage account Ads ## PARAMETERS ### -AccountName -Azure data share account name +The name of the Azure storage account that is the source of the data being shared. ```yaml Type: System.String @@ -210,7 +210,7 @@ Accept wildcard characters: False ``` ### -StorageAccountResourceId -Azure Storage Account ResourceId +Azure Storage Account ResourceId that is the source of the data being shared. ```yaml Type: System.String From 5a173f3251436e7b8fd4eb51299439f6cda2b4e1 Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Fri, 3 Feb 2023 17:40:24 +0530 Subject: [PATCH 2/7] Update NewAzDataShareDataSetMapping.cs --- .../DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs b/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs index 6a8001872b32..11624fabc663 100644 --- a/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs +++ b/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs @@ -104,7 +104,7 @@ public class NewAzDataShareDataSetMapping : AzureDataShareCmdletBase [Parameter( Mandatory = true, ValueFromPipelineByPropertyName = true, - HelpMessage = "Azure Storage Account ResourceId", + HelpMessage = "Azure Storage Account ResourceId that is the source of the data being shared.", ParameterSetName = ParameterSetNames.AdlsGen2DataSetParameterSet)] [ValidateNotNullOrEmpty] [ResourceIdCompleter(ResourceTypes.StorageAccount)] From 9772d700df27f7cfd209e85c9eccf26ab7087c46 Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Mon, 6 Feb 2023 11:06:37 +0530 Subject: [PATCH 3/7] Update NewAzDataShareDataSetMapping.cs --- .../DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs b/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs index 11624fabc663..44bc3a666a97 100644 --- a/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs +++ b/src/DataShare/DataShare/DataSetMapping/NewAzDataShareDataSetMapping.cs @@ -59,7 +59,7 @@ public class NewAzDataShareDataSetMapping : AzureDataShareCmdletBase ParameterSetName = ParameterSetNames.BlobDataSetParameterSet)] [Parameter( Mandatory = true, - HelpMessage = "Azure data share account name", + HelpMessage = "The name of the Azure storage account that is the source of the data being shared.", ParameterSetName = ParameterSetNames.AdlsGen2DataSetParameterSet)] [ResourceNameCompleter(ResourceTypes.Account, "ResourceGroupName")] public string AccountName { get; set; } From 0ef559a4fe8d1dbbc2be39d56535a2edf8939b28 Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Mon, 6 Feb 2023 11:38:20 +0530 Subject: [PATCH 4/7] Update GetAzDataShareDataSetMapping.cs --- .../DataShare/DataSetMapping/GetAzDataShareDataSetMapping.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataShare/DataShare/DataSetMapping/GetAzDataShareDataSetMapping.cs b/src/DataShare/DataShare/DataSetMapping/GetAzDataShareDataSetMapping.cs index 03505fecfd1a..165af895c7d0 100644 --- a/src/DataShare/DataShare/DataSetMapping/GetAzDataShareDataSetMapping.cs +++ b/src/DataShare/DataShare/DataSetMapping/GetAzDataShareDataSetMapping.cs @@ -53,7 +53,7 @@ public class GetAzDataShareDataSetMapping : AzureDataShareCmdletBase /// [Parameter( Mandatory = true, - HelpMessage = "Azure data share account name.", + HelpMessage = "The name of the Azure storage account that is the source of the data being shared.", ParameterSetName = ParameterSetNames.FieldsParameterSet)] [ValidateNotNullOrEmpty] [ResourceNameCompleter(ResourceTypes.Account, "ResourceGroupName")] From 0d7e672628231ffcd763df13082ba8115cd420a5 Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Mon, 6 Feb 2023 11:38:54 +0530 Subject: [PATCH 5/7] Update RemoveAzDataShareDataSetMapping.cs --- .../DataSetMapping/RemoveAzDataShareDataSetMapping.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataShare/DataShare/DataSetMapping/RemoveAzDataShareDataSetMapping.cs b/src/DataShare/DataShare/DataSetMapping/RemoveAzDataShareDataSetMapping.cs index 4cbdcd5984ec..0c8b6ff45bc7 100644 --- a/src/DataShare/DataShare/DataSetMapping/RemoveAzDataShareDataSetMapping.cs +++ b/src/DataShare/DataShare/DataSetMapping/RemoveAzDataShareDataSetMapping.cs @@ -53,7 +53,7 @@ public class RemoveAzDataShareDataSetMapping : AzureDataShareCmdletBase [Parameter( Mandatory = true, ParameterSetName = ParameterSetNames.FieldsParameterSet, - HelpMessage = "Azure data share account name")] + HelpMessage = "The name of the Azure storage account that is the source of the data being shared.")] [ValidateNotNullOrEmpty] [ResourceNameCompleter(ResourceTypes.Account, "ResourceGroupName")] public string AccountName { get; set; } @@ -152,4 +152,4 @@ public override void ExecuteCmdlet() } } } -} \ No newline at end of file +} From bceaca0f90942e6a59773e1e5fffb60016e1945c Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Mon, 6 Feb 2023 11:39:24 +0530 Subject: [PATCH 6/7] Update Get-AzDataShareDataSetMapping.md --- src/DataShare/DataShare/help/Get-AzDataShareDataSetMapping.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataShare/DataShare/help/Get-AzDataShareDataSetMapping.md b/src/DataShare/DataShare/help/Get-AzDataShareDataSetMapping.md index 10e4e9c73134..578c420e9a09 100644 --- a/src/DataShare/DataShare/help/Get-AzDataShareDataSetMapping.md +++ b/src/DataShare/DataShare/help/Get-AzDataShareDataSetMapping.md @@ -52,7 +52,7 @@ Type : Microsoft.DataShare/DataSetMappings ## PARAMETERS ### -AccountName -Azure data share account name. +The name of the Azure storage account that is the source of the data being shared. ```yaml Type: System.String From 65e224a48bb809532eaa5dff947d7d7424dafae0 Mon Sep 17 00:00:00 2001 From: navba-MSFT <57353862+navba-MSFT@users.noreply.github.com> Date: Mon, 6 Feb 2023 11:39:40 +0530 Subject: [PATCH 7/7] Update Remove-AzDataShareDataSetMapping.md --- .../DataShare/help/Remove-AzDataShareDataSetMapping.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DataShare/DataShare/help/Remove-AzDataShareDataSetMapping.md b/src/DataShare/DataShare/help/Remove-AzDataShareDataSetMapping.md index 828701625c1a..2f76283729dc 100644 --- a/src/DataShare/DataShare/help/Remove-AzDataShareDataSetMapping.md +++ b/src/DataShare/DataShare/help/Remove-AzDataShareDataSetMapping.md @@ -51,7 +51,7 @@ This commands removes the dataset named DSM from sharesubscription WikiAds. ## PARAMETERS ### -AccountName -Azure data share account name +The name of the Azure storage account that is the source of the data being shared. ```yaml Type: System.String