Skip to content

Conversation

@isolenov
Copy link

Description

  • 'Az.ManagedServiceIdentity' update based on GA version 2023-01-31. This is just a version update, no API changed.
  • 'UserAssignedIdentityAssociatedResource' still in preview thus uses 2022-01-31-preview

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you ran ./build-module.ps1 on you local and refresh all files?

@BethanyZhou BethanyZhou added the needs-author-feedback More information is needed from author to address the issue. label Feb 15, 2023
@isolenov
Copy link
Author

@BethanyZhou yes I did. run-module.ps1 and test-module.ps1 as well

@isolenov isolenov added ready to review and removed needs-author-feedback More information is needed from author to address the issue. labels Feb 15, 2023
@isolenov
Copy link
Author

isolenov commented Feb 15, 2023

Context of this change:
This update holds FIC feature GA announce. That feature is anticipated by majority of S400 AKS user to start a massive migration.
We hope to have it published any time before March-07. Hope this timeline is feasible.

@isolenov isolenov requested a review from BethanyZhou February 15, 2023 09:42
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please provide change log message here and we will move your changes to our main branch

@BethanyZhou BethanyZhou merged commit 9fdada5 into Azure:generation Feb 16, 2023
@BethanyZhou
Copy link
Contributor

Our regular schedule is 7th March. Does it work for you?

@isolenov
Copy link
Author

@BethanyZhou 7th March is perfect. thank you.
Changelog:

  • Upgraded to API version 2023-01-31.
  • Federated identity credentials GA version is available now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants