Merge preview into AzureRM.Storage.Location

[maddieclayton]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[praries880]

@maddieclayton There are a bunch of vmss and vm test failures in the on demand job... can you look at them?

08:43:23 (InvokeXUnitAll target) -> 
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVmssTests.TestSimpleNewVmssWithSystemAssignedUserAssignedIdentity [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVmssTests.TestSimpleNewVmss [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVmWithDefaultDomainName2 [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVmImageName [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestNewVmWin10 [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVmImageNameMicrosoftSqlUbuntu [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVm [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVmWithAvailabilitySet2 [FAIL] [D:\PowerShell-demand\build.proj]
08:43:23   D:\PowerShell-demand\src\ResourceManager\Common\Commands.ScenarioTests.ResourceManager.Common\EnvironmentSetupHelper.cs(643): error : Microsoft.Azure.Commands.Compute.Test.ScenarioTests.StrategiesVirtualMachineTests.TestSimpleNewVmWithSystemAssignedAndUserAssignedIdentity [FAIL] [D:\PowerShell-demand\build.proj]

[maddieclayton]

on demand here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/955/

[maddieclayton]

sign job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/790/

[maddieclayton]

new on demand: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/957/

[maddieclayton]

sign job: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/795/

[vladimir-shcherbakov]

Both on demand and sign builds failed.

[maddieclayton]

on demand here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/powershell-demand/960/

[maddieclayton]

new sign job: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/797/

[blueww]

@maddieclayton ， @cormacpayne

I see the new signed job still fail:https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/797/
Would you please help to look?

Remove-Item : Cannot find path
19:42:53 'C:\workspace\powershell-sign\src\Package\AzureRM.Profile\5.3.0' because it
19:42:53 does not exist.
19:42:53 At C:\workspace\powershell-sign\tools\PublishModules.ps1:686 char:13
19:42:53 + Remove-Item $TempRepoPath/$moduleName/$($ModuleMetadata.M ...
19:42:53 + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
19:42:53 + CategoryInfo : ObjectNotFound: (C:\workspace\po...M.Profile\5.3
19:42:53 .0:String) [Remove-Item], ItemNotFoundException
19:42:53 + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.Remov
19:42:53 eItemCommand
19:42:53
19:42:53 C:\workspace\powershell-sign\tools\PublishModules.ps1 : Publish-Module : The
19:42:53 module 'AzureRM.Profile' with version '5.3.0' cannot be
19:42:53 published as the current version '5.3.0' is already available in the
19:42:53 repository 'C:\workspace\powershell-sign\src\Package'.

[maddieclayton]

new sign job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/800/

@blueww Sorry for the delay, I have run into more merge issues with this PR than with all of my time here combined. Currently it seems like the sign job is failing because the Storage team and the Stack team both made significant changes to the publishmodules.ps1 script that caused issues with the signing process. Hopefully this fixes it. I'll take a look in the morning if it is still failing.

[blueww]

@maddieclayton , @cormacpayne
The signed build pass https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/800/

I have validated the “AzureRM.Storage.5.0.3-preview.nupkg” in https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/800/artifact/src/Package/

All test Pass, only the version is not correct.
Since our last release is “AzureRm.Storage.5.0.3-preview”, we should use version “AzureRm. Storage.5.0.4-preview” for this release.

I have send a commit to update the version to 5.0.4-preview.
And the signed build is running in https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/801/

If the build pass, we only need to do a sanity check for this package, and then can release the signed package.

[blueww]

The signed build has passed with my commit to upgrade version to “AzureRm. Storage.5.0.4-preview”.
https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/801

I have sanity check the AzureRM.Storage.5.0.4-preview.nupkg, and all works well.

We can release this AzureRM.Storage.5.0.4-preview.nupkg, like the before release.
I have scheduled a meeting to track the release tomorrow.

Please help to update me when this is released. I need to do a sanity check after release.

And we can also merge this PR now, as all build pass.