Skip to content

Print Settings #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Print Settings #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a51391d
Respect current settings for printing and allow specifying additional…
Danielku15 Dec 31, 2020
79624eb
Update jquery method
Danielku15 Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/platform/javascript/AlphaTabApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import { AlphaSynthWebWorkerApi } from '@src/platform/javascript/AlphaSynthWebWo
import { BrowserUiFacade } from '@src/platform/javascript/BrowserUiFacade';
import { ProgressEventArgs } from '@src/ProgressEventArgs';
import { Settings } from '@src/Settings';
import { JsonConverter } from '@src/model/JsonConverter';
import { SettingsSerializer } from '@src/generated/SettingsSerializer';

/**
* @target web
Expand All @@ -23,7 +25,7 @@ export class AlphaTabApi extends AlphaTabApiBase<unknown> {
super.tex(tex, browser.parseTracks(tracks));
}

public print(width: string): void {
public print(width: string, additionalSettings:unknown = null): void {
// prepare a popup window for printing (a4 width, window height, centered)
let preview: Window = window.open('', '', 'width=0,height=0')!;
let a4: HTMLElement = preview.document.createElement('div');
Expand Down Expand Up @@ -64,14 +66,12 @@ export class AlphaTabApi extends AlphaTabApiBase<unknown> {
preview.moveTo(left, top);
preview.focus();
// render alphaTab
let settings: Settings = new Settings();
settings.core.scriptFile = this.settings.core.scriptFile;
settings.core.fontDirectory = this.settings.core.fontDirectory;
let settings: Settings = JsonConverter.jsObjectToSettings(JsonConverter.settingsToJsObject(this.settings));
settings.core.enableLazyLoading = false;
settings.core.useWorkers = false;
settings.display.scale = 0.8;
settings.display.stretchForce = 0.8;
settings.display.resources = this.settings.display.resources;
SettingsSerializer.fromJson(settings, additionalSettings);
let alphaTab: AlphaTabApi = new AlphaTabApi(a4, settings);
alphaTab.renderer.postRenderFinished.on(() => {
alphaTab.canvasElement.height = -1;
Expand Down
4 changes: 2 additions & 2 deletions src/platform/javascript/JQueryAlphaTab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ export class JQueryAlphaTab {
context.destroy();
}

public print(element: jQuery, context: AlphaTabApi, width: string): void {
context.print(width);
public print(element: jQuery, context: AlphaTabApi, width: string, additionalSettings?: unknown): void {
context.print(width, additionalSettings);
}

public load(element: jQuery, context: AlphaTabApi, data: unknown, tracks?: number[]): boolean {
Expand Down