Skip to content

Fixed map parsing on JSON serializer #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fixed map parsing on JSON serializer #501

merged 1 commit into from
Jan 7, 2021

Conversation

@Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Jan 7, 2021

Issues

Fixes #500

Proposed changes

Use JsonHelper.forEach to iterate object/map objects correctly when parsing JSON.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 7, 2021
@Danielku15 Danielku15 merged commit dee694d into develop Jan 7, 2021
@Danielku15 Danielku15 deleted the feature/fix-json-map-parsing branch January 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Danielku15 Danielku15

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Development version ignoring data htmls

2 participants

@Danielku15