Use signext lowering in wasm-opt #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
changed the title
maurolacy
force-pushed
the
update-binaryen-rust
branch
from
1512dd7 to
79663f2
Compare
webmaster128
approved these changes
Jul 28, 2023
Member
webmaster128
left a comment
webmaster128
left a comment
There was a problem hiding this comment.
sweet
I suggest a comment to the wasm-opt calls along the lines of
--signext-lowering is needed to support blockchain runnning CosmWasm < 1.3. It can be removed eventually
Co-authored-by: Simon Warta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127.
Updates to binaryen v114 and Rust 1.71.0.
This results in slightly bigger (1/2%) binaries compared to the current version with binaryen v110 and Rust v1.69.0 (and no signext lowering).