Skip to content

Commit 6438921

Browse files
authored
Merge pull request #1514 from Hirobreak/404-event
more on handling event 404 with new banner type
2 parents 8a9bdfc + f39ab11 commit 6438921

File tree

5 files changed

+16
-9
lines changed

5 files changed

+16
-9
lines changed

email_mailbox/src/components/Message.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ const renderMessageType = props => {
2020
props.type === MessageType.SUCCESS ||
2121
props.type === MessageType.ERROR ||
2222
props.type === MessageType.ESTABLISH ||
23-
props.type === MessageType.ANNOUNCEMENT
23+
props.type === MessageType.ANNOUNCEMENT ||
24+
props.type === MessageType.REQUIREMENT
2425
) {
2526
return <MessageStandard {...props} />;
2627
} else if (props.type === MessageType.QUESTION) {
@@ -97,6 +98,8 @@ const defineMessageClass = type => {
9798
return 'message-establish';
9899
case MessageType.ANNOUNCEMENT:
99100
return 'message-announcement';
101+
case MessageType.REQUIREMENT:
102+
return 'message-requirement';
100103
default:
101104
break;
102105
}
@@ -120,7 +123,8 @@ export const MessageType = {
120123
SUCCESS: 4,
121124
ERROR: 5,
122125
ESTABLISH: 6,
123-
ANNOUNCEMENT: 7
126+
ANNOUNCEMENT: 7,
127+
REQUIREMENT: 8
124128
};
125129

126130
export const MessageActionStatus = {

email_mailbox/src/components/MessageWrapper.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ class MessageWrapper extends Component {
113113
displayMessage: true
114114
};
115115
this.setState(newState, () => {
116+
if (type === MessageType.REQUIREMENT) return;
116117
const isImportantMessage =
117118
ask ||
118119
priority === messagePriorities.HIGH ||

email_mailbox/src/components/message.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
}
3737

3838
&.message-suggestion,
39+
&.message-requirement,
3940
&.message-announcement {
4041
background-color: #0091ff;
4142
border-color: #0091ff;

email_mailbox/src/data/message.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,10 @@ const messagesContent = {
242242
announcement: {
243243
priority: messagePriorities.MEDIUM,
244244
description: ''
245+
},
246+
requirement: {
247+
priority: messagePriorities.LOW,
248+
description: ''
245249
}
246250
}
247251
};

email_mailbox/src/utils/electronEventInterface.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,24 +1471,21 @@ const handleUpdateDeviceTypeEvent = async ({ rowid }) => {
14711471
return status === 200 ? { rowid } : { rowid: null };
14721472
};
14731473

1474-
const handleActionRequiredEvent = async (
1475-
{ rowid, params },
1476-
accountRecipientId
1477-
) => {
1474+
const handleActionRequiredEvent = async ({ params }, accountRecipientId) => {
14781475
if (accountRecipientId !== myAccount.recipientId) return { rowid: null };
14791476

14801477
const { code } = params;
14811478
const updateAnnouncement = await getNews({ code });
14821479

14831480
const messageData = {
1484-
...Messages.news.announcement,
1485-
type: MessageType.ANNOUNCEMENT,
1481+
...Messages.news.requirement,
1482+
type: MessageType.REQUIREMENT,
14861483
description: updateAnnouncement.title,
14871484
actionHandlerKey: actionHandlerKeys.error.billing,
14881485
action: string.messages.actionRequired.update
14891486
};
14901487
emitter.emit(Event.DISPLAY_MESSAGE, messageData);
1491-
return { rowid };
1488+
return { rowid: null };
14921489
};
14931490

14941491
const handleSuspendedAccountEvent = accountRecipientId => {

0 commit comments

Comments
 (0)