From 14a71efa6a79eb5e8d0e0b8a2cb662f1507452df Mon Sep 17 00:00:00 2001 From: Hannah Kim Date: Mon, 20 Oct 2025 16:43:01 -0400 Subject: [PATCH 1/3] use glob regex --- CODEOWNERS | 84 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 44 insertions(+), 40 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index b3f43cc8e1..a76aa505fe 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -3,71 +3,75 @@ # default owner * @DataDog/dd-trace-go-guild # tracing -/contrib @DataDog/apm-go @Datadog/apm-idm-go -/ddtrace @DataDog/apm-go +/contrib/** @DataDog/apm-go @Datadog/apm-idm-go +/ddtrace/** @DataDog/apm-go # profiling -/profiler @DataDog/profiling-go -/internal/traceprof @DataDog/profiling-go +/profiler/** @DataDog/profiling-go +/internal/traceprof/** @DataDog/profiling-go # appsec -/appsec @DataDog/asm-go -/internal/appsec @DataDog/asm-go -/instrumentation/appsec @DataDog/asm-go +/appsec/** @DataDog/asm-go +/internal/appsec/** @DataDog/asm-go +/instrumentation/appsec/** @DataDog/asm-go /contrib/**/*appsec*.go @DataDog/asm-go /.github/workflows/appsec.yml @DataDog/asm-go -/contrib/envoyproxy @DataDog/asm-go -/contrib/haproxy @DataDog/asm-go -/contrib/k8s.io/gateway-api @DataDog/asm-go +/contrib/envoyproxy/** @DataDog/asm-go +/contrib/haproxy/** @DataDog/asm-go +/contrib/k8s.io/gateway-api/** @DataDog/asm-go # capabilities - config, dynamic config, remote config -/internal/env @DataDog/apm-sdk-capabilities-go -/internal/stableconfig @DataDog/apm-sdk-capabilities-go -/internal/globalconfig @DataDog/apm-sdk-capabilities-go -/internal/remoteconfig @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/dynamic_config.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/remote_config.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/otel_dd_mappings.go @DataDog/apm-sdk-capabilities-go +/internal/env/** @DataDog/apm-sdk-capabilities-go +/internal/stableconfig/** @DataDog/apm-sdk-capabilities-go +/internal/globalconfig/** @DataDog/apm-sdk-capabilities-go +/internal/remoteconfig/** @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/dynamic_config.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/remote_config.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/otel_dd_mappings.go @DataDog/apm-sdk-capabilities-go + # capabilities - telemetry -/internal/telemetry @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/telemetry.go @DataDog/apm-sdk-capabilities-go +/internal/telemetry/** @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/telemetry.go @DataDog/apm-sdk-capabilities-go + # capabilities - sampling -/ddtrace/tracer/tracer.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/sampler.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/rules_sampler.go @DataDog/apm-sdk-capabilities-go -/internal/samplernames @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/tracer.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/sampler.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/rules_sampler.go @DataDog/apm-sdk-capabilities-go +/internal/samplernames/** @DataDog/apm-sdk-capabilities-go + # capabilities - context, propagation, injection/extraction -/ddtrace/baggage @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/textmap.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/spancontext.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/context.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/propagator.go @DataDog/apm-sdk-capabilities-go -/ddtrace/tracer/propagating_tags.go @DataDog/apm-sdk-capabilities-go +/ddtrace/baggage/** @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/textmap.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/spancontext.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/context.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/propagator.go @DataDog/apm-sdk-capabilities-go +/ddtrace/tracer/propagating_tags.go @DataDog/apm-sdk-capabilities-go + # capabilities- OTel integration -/ddtrace/opentelemetry @DataDog/apm-sdk-capabilities-go +/ddtrace/opentelemetry/** @DataDog/apm-sdk-capabilities-go # datastreams -/datastreams @Datadog/data-streams-monitoring -/internal/datastreams @Datadog/data-streams-monitoring +/datastreams/** @Datadog/data-streams-monitoring +/internal/datastreams/** @Datadog/data-streams-monitoring # civisibility -/civisibility @DataDog/ci-app-libraries -/internal/civisibility @DataDog/ci-app-libraries +/civisibility/** @DataDog/ci-app-libraries +/internal/civisibility/** @DataDog/ci-app-libraries # llm observability -/llmobs @DataDog/ml-observability -/internal/llmobs @DataDog/ml-observability +/llmobs/** @DataDog/ml-observability +/internal/llmobs/** @DataDog/ml-observability # Gitlab configuration .gitlab-ci.yml @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability -/.gitlab-ci @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability +/.gitlab-ci/** @DataDog/dd-trace-go-guild @DataDog/apm-ecosystems-reliability # Orchestrion -/internal/orchestrion @DataDog/apm-orchestrion +/internal/orchestrion/** @DataDog/apm-orchestrion /**/orchestrion.yml @DataDog/apm-orchestrion # Serverless -/contrib/aws/datadog-lambda-go @DataDog/apm-serverless @DataDog/serverless-aws +/contrib/aws/datadog-lambda-go/** @DataDog/apm-serverless @DataDog/serverless-aws # no owner: changes to these files will not automatically ping any particular # team and can be reviewed by anybody with the appropriate permissions. This is @@ -76,4 +80,4 @@ **/go.mod **/go.sum go.work -go.work.sum +go.work.sum \ No newline at end of file From d6504cab42c223e31fe59467b1f50f5da802fe51 Mon Sep 17 00:00:00 2001 From: Hannah Kim Date: Tue, 21 Oct 2025 01:59:24 -0400 Subject: [PATCH 2/3] debug: echo each line in the xml file --- .github/actions/add-codeowners/codeowners.sh | 1 + CODEOWNERS | 54 ++++++++++---------- 2 files changed, 28 insertions(+), 27 deletions(-) diff --git a/.github/actions/add-codeowners/codeowners.sh b/.github/actions/add-codeowners/codeowners.sh index bdcc9077c6..087ac9f563 100755 --- a/.github/actions/add-codeowners/codeowners.sh +++ b/.github/actions/add-codeowners/codeowners.sh @@ -9,6 +9,7 @@ for file in gotestsum-report*.xml; do echo -e "\n" >> $file while read p; do + echo "line: $p" # we might try to report gotestsum-report.xml multiple times, so don't # calculate codeowners more times than we need if [[ "$p" =~ \