From 5a8b7b0a54ad877068dfde07c951fc7b4d9f8c51 Mon Sep 17 00:00:00 2001 From: Alexey Kuznetsov Date: Tue, 14 Oct 2025 10:13:16 -0400 Subject: [PATCH] Minor cleanup. --- .../serialization/GrowableBufferTest.java | 22 +++++++++---------- .../datadog/smoketest/ProcessManager.groovy | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/communication/src/test/java/datadog/communication/serialization/GrowableBufferTest.java b/communication/src/test/java/datadog/communication/serialization/GrowableBufferTest.java index 929a369d867..9b0c06daecd 100644 --- a/communication/src/test/java/datadog/communication/serialization/GrowableBufferTest.java +++ b/communication/src/test/java/datadog/communication/serialization/GrowableBufferTest.java @@ -1,6 +1,6 @@ package datadog.communication.serialization; -import static groovy.util.GroovyTestCase.assertEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -49,8 +49,8 @@ public void testBufferReset() { gb.put((byte) 42); ByteBuffer slice = gb.slice(); - assertEquals(gb.messageCount(), 0); - assertEquals(slice.get(), 42); + assertEquals(0, gb.messageCount()); + assertEquals(42, slice.get()); } @Test @@ -73,13 +73,13 @@ public void testPutVariants() { gb.put(new byte[] {-128}, 0, 1); ByteBuffer slice = gb.slice(); - assertEquals(slice.getShort(), (short) 1); - assertEquals(slice.getChar(), (char) 2); - assertEquals(slice.getInt(), 4); - assertEquals(slice.getLong(), 8L); - assertEquals(slice.getFloat(), 16.0f); - assertEquals(slice.getDouble(), 32.0); - assertEquals(slice.get(), (byte) 64); - assertEquals(slice.get(), (byte) -128); + assertEquals((short) 1, slice.getShort()); + assertEquals((char) 2, slice.getChar()); + assertEquals(4, slice.getInt()); + assertEquals(8L, slice.getLong()); + assertEquals(16.0f, slice.getFloat()); + assertEquals(32.0, slice.getDouble()); + assertEquals((byte) 64, slice.get()); + assertEquals((byte) -128, slice.get()); } } diff --git a/dd-smoke-tests/src/main/groovy/datadog/smoketest/ProcessManager.groovy b/dd-smoke-tests/src/main/groovy/datadog/smoketest/ProcessManager.groovy index 64effc049ea..76b6a0ae754 100644 --- a/dd-smoke-tests/src/main/groovy/datadog/smoketest/ProcessManager.groovy +++ b/dd-smoke-tests/src/main/groovy/datadog/smoketest/ProcessManager.groovy @@ -268,7 +268,7 @@ abstract class ProcessManager extends Specification { while (reader.read(buffer) != -1) { buffer.flip() while (buffer.hasRemaining()) { - int c = buffer.get() + char c = buffer.get() if (c == '\n' || c == '\r') { break }