-
Notifications
You must be signed in to change notification settings - Fork 467
feat(appsec): instrument urllib3 when appsec is enabled #15090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appsec): instrument urllib3 when appsec is enabled #15090
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 9 ms. The average import time from base is: 240 ± 4 ms. The import time difference between this PR and base is: 0.7 ± 0.3 ms. The difference is not statistically significant (z = 2.35). Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate florentin.labelle/APPSEC-59665/patch-urllib3-when-appsec-is-on (c373827) with baseline main (dcd5f1a) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.592ms (SLO: <22.300ms -7.7%) vs baseline: +0.3% Memory: ✅ 65.997MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: ~same Memory: ✅ 64.161MB (SLO: <67.000MB -4.2%) vs baseline: +4.7% ✅ iastTime: ✅ 20.466ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ profilerTime: ✅ 15.561ms (SLO: <16.550ms -6.0%) vs baseline: +0.4% Memory: ✅ 53.815MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.563ms (SLO: <21.750ms -5.5%) vs baseline: +0.2% Memory: ✅ 66.033MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.354ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.3% Memory: ✅ 67.084MB (SLO: <69.500MB -3.5%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.438ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 66.021MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.669ms (SLO: <23.500ms -3.5%) vs baseline: -0.3% Memory: ✅ 67.201MB (SLO: <68.000MB 🟡 -1.2%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.330ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 66.001MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.577ms (SLO: <17.500ms -5.3%) vs baseline: -0.3% Memory: ✅ 65.687MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 20.460ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 71.472MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.482ms (SLO: <19.650ms -5.9%) vs baseline: +0.1% Memory: ✅ 65.952MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.745ms (SLO: <20.100ms -6.7%) vs baseline: ~same Memory: ✅ 65.706MB (SLO: <67.000MB 🟡 -1.9%) vs baseline: +4.5% ✅ tracer-no-middlewareTime: ✅ 20.123ms (SLO: <21.500ms -6.4%) vs baseline: +0.1% Memory: ✅ 66.159MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-no-templatesTime: ✅ 20.250ms (SLO: <22.000ms -8.0%) vs baseline: -0.2% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.042ms (SLO: <19.850ms -9.1%) vs baseline: -0.4% Memory: ✅ 65.746MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.140ms (SLO: <19.400ms -6.5%) vs baseline: +0.2% Memory: ✅ 65.662MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.4% ✅ tracer-enabledTime: ✅ 18.100ms (SLO: <19.450ms -6.9%) vs baseline: +0.2% Memory: ✅ 65.706MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.6% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.080ms (SLO: <2.300ms -9.6%) vs baseline: +0.2% Memory: ✅ 52.416MB (SLO: <53.500MB -2.0%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 2.068ms (SLO: <2.250ms -8.1%) vs baseline: -0.5% Memory: ✅ 52.514MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.091ms (SLO: <2.300ms -9.1%) vs baseline: +1.1% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: +0.3% Memory: ✅ 62.331MB (SLO: <65.000MB -4.1%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.616ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 62.232MB (SLO: <65.000MB -4.3%) vs baseline: +4.6% ✅ appsec-telemetryTime: ✅ 4.584ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 62.286MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.5% Memory: ✅ 45.160MB (SLO: <47.000MB -3.9%) vs baseline: +4.5% ✅ iast-getTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: -0.6% Memory: ✅ 42.085MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.909ms (SLO: <2.100ms -9.1%) vs baseline: -0.6% Memory: ✅ 46.203MB (SLO: <47.000MB 🟡 -1.7%) vs baseline: +4.5% ✅ resource-renamingTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: -0.5% Memory: ✅ 52.563MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.5% ✅ tracerTime: ✅ 3.347ms (SLO: <3.650ms -8.3%) vs baseline: -0.1% Memory: ✅ 52.457MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.2% ✅ tracer-nativeTime: ✅ 3.345ms (SLO: <3.650ms -8.3%) vs baseline: -0.4% Memory: ✅ 58.098MB (SLO: <60.000MB -3.2%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.975ms (SLO: <4.200ms -5.4%) vs baseline: +0.2% Memory: ✅ 62.305MB (SLO: <66.000MB -5.6%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.437ms (SLO: <2.800ms 📉 -12.9%) vs baseline: -0.4% Memory: ✅ 59.041MB (SLO: <60.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.063ms (SLO: <2.250ms -8.3%) vs baseline: ~same Memory: ✅ 52.435MB (SLO: <54.500MB -3.8%) vs baseline: +4.5%
|
4d716cb to
803afbe
Compare
803afbe to
c373827
Compare
Description
Testing
Risks
Additional Notes