React Native Support

[BosEriko]

📦 Published PR as canary version: 3.1.3-canary.15.931587d.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

[ericclemmons]

How did a dedicated Editmode.native.jsx go?

[BosEriko]

How did a dedicated Editmode.native.jsx go?
@ericclemmons

I didn't go with it because I thought it might be too overkill? And also confusing in the long run. I just think the current approach will make more sense if someone is not using React Native. At least that's how I see it.

What do you think?

[ericclemmons]

The .native extensions is basically a way of opting into RN support without breaking non-RN projects.

From the looks of this PR, RN is now a required dependency for consumers, which would be a breaking change.

Am I reading that correctly?

Another way libraries support both web and RN is having a separate entry point: editmode-react/native.

Anyway, there are a variety of methods, but the primary goal is that non-RN projections won't have RN as a dependency directly or indirectly (from this lib).

[BosEriko]

Googled a few stackoverflow answers.

https://stackoverflow.com/questions/46455202/react-native-project-do-not-have-index-ios-js-or-index-android-js

Says there that separate entry routes do not work anymore after 0.49.3. They also said to use { Platform } instead. Which is what we have right now.

From the looks of this PR, RN is now a required dependency for consumers, which would be a breaking change.

I'm not sure how an import can be a breaking change? It will probably be an extra kb, though.

[ericclemmons]

That’s interesting! I was going off of https://reactnative.dev/docs/platform-specific-code#platform-specific-extensions If you tested it and it works and doesn’t affect web, feel free to ship! Thanks for the extra info :) -- Sent from Gmail Mobile

[BosEriko]

@ericclemmons that is so weird. The docs say 0.63 so it should probably work, right? I couldn't make it work and when I searched for it they were saying that it shouldn't work anymore.

Is this by any chance a mistake in the docs? Or am I just doing something wrong?

[ericclemmons]

@BosEriko We can revisit this, but if things are working in your testing, let's ship 👍

Track bundle-sizes here post-release:

https://bundlephobia.com/result?p=editmode-react

[github-actions]

🚀 PR was released in v3.1.3 🚀

[ericclemmons]

• react should be both in devDependencies and peerDepenencies because we depend on it for local development directly (e.g. import React from "react") and consumers should have it in their project.
• react-dom should be a peerDependencies because consumers should have it in their project.
• react-native can be a devDependencies if we're using it for tests or in a local project, but likely won't need it listed anywhere at all.

[ericclemmons]

We can't safely depend on react-native within a web environment because of how react-native publishes to NPM (under the expectation that it's bundled via expo or metro bundler)

[ericclemmons]

We need to re-investigate splitting Editmode.jsx into 2 files:

• Editmode.jsx for web
• Editmode.native.jsx for react-native