-
Notifications
You must be signed in to change notification settings - Fork 3
useChunk(defaultContent, props) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…useChunk * 'master' of github.com:Editmode-app/editmode-react: Bump version to: 1.0.22 [skip ci] Add @ericclemmons as a contributor Update CHANGELOG.md [skip ci]
With the recent API publish, I found that the |
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://app.asana.com/0/0/1177340596341441/f
This is a proof-of-concept for
useChunk
based on my integration with customer apps. The benefit ofuseChunk
is that it allows for experimenting with dynamic content by computingcontent_key
ad run-time.identifier
isn't immediately known for dynamic content:In the previous example, the chunk
identifier
would have to be tracked through the component hierarchies to dynamically render{children}
inside of a<Chunk>
.<Chunk identifier="...">Default Content</Chunk>
still works as expected, but internally usesuseChunk
.useChunk(defaultContent, props)
returns{ content, element }
:content
is the value ofchunk.content
from the API.element
is the value ofrenderChunk(chunk)
, for ease-of-use.Based on experimentation with
useChunk(defaultContent)
, there may be a need to update<Editmode>
provider to includeprojectId
.useChunk(defaultContent)
will computecontent_key
and request using that in absence ofidentifier
.📦 Published PR as canary version:
1.0.23-canary.3.1fd3776.0
✨ Test out this PR locally via: