add tag filter, and limit functionality for collection chunks #7
Conversation
notthatjen
added
documentation
src/ChunkCollection.jsx
Outdated
| let urlParams = toQuery({ | ||
| collection_identifier: identifier, | ||
| limit: limit || "", | ||
| 'tags[]': tags || [], | ||
| }) |
There was a problem hiding this comment.
Would https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/URLSearchParams work for this as well?
There was a problem hiding this comment.
Oh! You're right. I'll use this instead thanks 💯
src/Editmode.jsx
Outdated
| script.src = "https://static.editmode.com/editmode@^1.0.0/dist/editmode.js"; | ||
| script.src = devMode ? "http://static.lvh.me:3002/editmode@^1.0.0/dist/editmode.js" : "https://static.editmode.com/editmode@^1.0.0/dist/editmode.js"; |
There was a problem hiding this comment.
Would a check for window.location.href.includes("localhost") work for this ternary?
There was a problem hiding this comment.
Smart! Yeah, I'll update this line 👍
There was a problem hiding this comment.
Actually, I'll remove the devMode ternary for now, this is just for me anyway haha.
Using window.location.href.includes("localhost") will return an error for other devs that will use editmode-react locally, since the library is pointing to editmode local server instead of the prod one.
|
🚀 PR was released in |
Changes
tagattribute inChunkCollectionlimitattribute inChunkCollectiontoQueryutil - this converts object to url parameters📦 Published PR as canary version:
3.0.1-canary.7.dba0530.0✨ Test out this PR locally via: