review feedback

Author: dcog989

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs

@@ -155,12 +155,18 @@ private void StartFirefoxBookmarkTimer()
 
         _firefoxBookmarkTimer = new PeriodicTimer(FirefoxPollingInterval);
 
+        var timer = _firefoxBookmarkTimer!;
         _ = Task.Run(async () =>
         {
-            while (await _firefoxBookmarkTimer.WaitForNextTickAsync(_cancellationTokenSource.Token))
+            try
             {
-                await ReloadFirefoxBookmarksAsync();
+                while (await timer.WaitForNextTickAsync(_cancellationTokenSource.Token))
+                {
+                    await ReloadFirefoxBookmarksAsync();
+                }
             }
+            catch (OperationCanceledException) { }
+            catch (ObjectDisposedException) { }
         }, _cancellationTokenSource.Token);
     }
 

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Services/FaviconService.cs

@@ -74,9 +74,11 @@ private void LoadFailedFetches()
 
     private async Task SaveFailedFetchesAsync()
     {
-        await _fileLock.WaitAsync(_cts.Token);
+        var acquired = false;
         try
         {
+            await _fileLock.WaitAsync(_cts.Token);
+            acquired = true;
             var json = JsonSerializer.Serialize(_failedFetches);
             await File.WriteAllTextAsync(_failsFilePath, json, _cts.Token);
         }
@@ -87,7 +89,8 @@ private async Task SaveFailedFetchesAsync()
         }
         finally
         {
-            _fileLock.Release();
+            if (acquired)
+                _fileLock.Release();
         }
     }