Remove usage of _settingsVM._settings and make _settings private

Author: Jack251970

Flow.Launcher/PublicAPIInstance.cs

@@ -27,18 +27,21 @@
 using System.Collections.Specialized;
 using CommunityToolkit.Mvvm.DependencyInjection;
 using Flow.Launcher.Core;
+using Flow.Launcher.Infrastructure.UserSettings;
 
 namespace Flow.Launcher
 {
     public class PublicAPIInstance : IPublicAPI
     {
+        private readonly Settings _settings;
         private readonly SettingWindowViewModel _settingsVM;
         private readonly MainViewModel _mainVM;
 
         #region Constructor
 
         public PublicAPIInstance()
         {
+            _settings = Ioc.Default.GetRequiredService<Settings>();
             _settingsVM = Ioc.Default.GetRequiredService<SettingWindowViewModel>();
             _mainVM = Ioc.Default.GetRequiredService<MainViewModel>();
             GlobalHotkey.hookedKeyboardCallback = KListener_hookedKeyboardCallback;
@@ -247,7 +250,7 @@ public void SavePluginSettings()
         public void OpenDirectory(string DirectoryPath, string FileNameOrFilePath = null)
         {
             using var explorer = new Process();
-            var explorerInfo = _settingsVM._settings.CustomExplorer;
+            var explorerInfo = _settings.CustomExplorer;
 
             explorer.StartInfo = new ProcessStartInfo
             {
@@ -268,7 +271,7 @@ private void OpenUri(Uri uri, bool? inPrivate = null)
         {
             if (uri.Scheme == Uri.UriSchemeHttp || uri.Scheme == Uri.UriSchemeHttps)
             {
-                var browserInfo = _settingsVM._settings.CustomBrowser;
+                var browserInfo = _settings.CustomBrowser;
 
                 var path = browserInfo.Path == "*" ? "" : browserInfo.Path;
 

Flow.Launcher/ViewModel/SettingWindowViewModel.cs

@@ -1,12 +1,11 @@
-using CommunityToolkit.Mvvm.DependencyInjection;
-using Flow.Launcher.Infrastructure.UserSettings;
+using Flow.Launcher.Infrastructure.UserSettings;
 using Flow.Launcher.Plugin;
 
 namespace Flow.Launcher.ViewModel;
 
 public partial class SettingWindowViewModel : BaseModel
 {
-    public readonly Settings _settings; 
+    private readonly Settings _settings; 
 
     public SettingWindowViewModel(Settings settings)
     {