Wifi AND/OR Ethernet

[infrafast]

Hello my device can connect either ethernet or wifi (esp32 + w5500)

My understanding is that the MIDI object are created statically by calling

APPLEMIDI_CREATE_INSTANCE

Is there a way to instanciate this dynamically using EthernetUDP in case the ethernet connection is establish and equally with WiFiUDP in case WiFI connection is made

Otherwise, I think I have to declare twice the interface which would consume a lot of memory.

APPLEMIDI_CREATE_INSTANCE(EthernetUDP, ETHMIDI, "AppleMIDI-Arduino", DEFAULT_CONTROL_PORT);
APPLEMIDI_CREATE_INSTANCE(WiFiUDP, WIFIMIDI, "AppleMIDI-Arduino", DEFAULT_CONTROL_PORT);

Any idea/thought or advise welcome :-)
Thanks

[lathoub]

Question for related repo: Arduino-AppleMIDI

instanciate this dynamically

I did try this in the past, but dynamic object creation conflicts with the memory management of microcontrollers (the libs were created for Arduino's R3 with Ethernet shield). This library and Arduino-AppleMIDI are designed and build with no dynamic object creation or inheritance - avoiding a Stack crash.

That said, microcontrollers are getting bigger qua memory and cpu and OS capabilities, opening the door for dynamic allocation.

Go ahead and try, a report back - I'd love to learn from your experience

[infrafast]

OK, took a bit more time than expected but I finally tested WiFi and I can confirm it works when created dyncamically. Here is working example on ESP32-S3 :

#include <WiFi.h>
#include <WiFiUdp.h>
#include <AppleMIDI.h>

const char* ssid     = "ssid";
const char* password = "password";

APPLEMIDI_NAMESPACE::AppleMIDISession<WiFiUDP> *appleMidiSession;
MidiInterface<APPLEMIDI_NAMESPACE::AppleMIDISession<WiFiUDP>, APPLEMIDI_NAMESPACE::AppleMIDISettings> *myMidi;

void setup(){
  Serial.begin(115200);
  WiFi.mode(WIFI_STA);
  WiFi.begin(ssid, password);
  while (WiFi.status() != WL_CONNECTED) delay(100);

  appleMidiSession = new APPLEMIDI_NAMESPACE::AppleMIDISession<WiFiUDP>("appleMidi", 5004);
  myMidi = new MidiInterface<APPLEMIDI_NAMESPACE::AppleMIDISession<WiFiUDP>,APPLEMIDI_NAMESPACE::AppleMIDISettings>(*appleMidiSession); 
  appleMidiSession->begin();
  appleMidiSession->setHandleConnected([](const APPLEMIDI_NAMESPACE::ssrc_t & ssrc, const char* name) {
    AM_DBG(F("Connected to session"), ssrc, name);
  });
  appleMidiSession->setHandleDisconnected([](const APPLEMIDI_NAMESPACE::ssrc_t & ssrc) {
    AM_DBG(F("Disconnected"), ssrc);
  });   
}

void loop(){
    myMidi->read();  
}

When I can I will test with Ethernet

[lathoub]

Nice work!
To improve readability you can wrap APPLEMIDI_NAMESPACE::AppleMIDISession<WiFiUDP> in a MACRO

When done, add it to the examples in the home directly of Arduino-AppleMIDI-Library with a PR

[infrafast]

Well, I am currently working on a overall wrapper that would manipulate a generic midiClient (which is instantiated based on ETH or WIFI) I will post the code once fully tested. But before that , I have to report on Ethernet some strange behaviour.
Once the object AppleMIDISession and MidiInterface are instantiated the following sequence is fed into the console and repeat multiple time before trigerring the watchdog:

AppleMidiWithInterfaceWrapper(Interval-AppleMidi-Eth,5004)
...all Eth object instantiated
0    1    2    3    4    5    6    7    8    9    10   11   12   13   14   15   16   17   18   19   20   21   22   23   24   25   26   27   28   29   30   31   32   33   34   35   36   37   38   39   40   41   42   43   44   45   46   47   48   49   50   51   52   53   54   55   56   57   58   59   60   61   62   63 0x78 0x25 0x04 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00   0    1    2    3    4    5    6    7    8    9    10   11   12   13   14   15   16   17   18   19   20   21   22   23   24   25   26   27   28   29   30   31   32   33   34   35   36   37   38   39   40   41   42   43   44   45   46   47   48   49   50   51   52   53   54   55   56   57   58   59   60   61   62 0x25 0x04 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 

etc...

1. would you have any idea of the meaning ?
2. how do we disable the dump (useful but just curious to be sure I will be able to do that for PROD)
   Thanks

[lathoub]

if you define #define SerialMon, debugging messages will appear

See here

[infrafast]

Ok thanks, that's touse debugging messafe, but actually I was asking how to disable the dump of hexa values coming in ?

[infrafast]

All right, I have implemented example in the example directory to demonstrate usage of dynamic instantiation instead of macro
see pull request