Skip to content

[Backport 6.1] Only make tiny adjustments to dx and dy if both need it #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2020
Merged

[Backport 6.1] Only make tiny adjustments to dx and dy if both need it #3638

merged 1 commit into from
Jul 10, 2020

Conversation

@github-actions
Copy link
Contributor

Backport 9ec3a3a from #3631

@PaulWessel @github-actions
Only make tiny adjustments to dx and dy if both need it (#3631)
33494a5 
* Only make tiny adjustments to dx and dy if both need it

We have a roundoff-patrol checker that looks to see if an geograic grid increment is close to a multiple of integer seconds or minutes.  if it is close enough then we set it to the exact.  however, the case that triggered this discussion was close enough to 3s in x but not in y.  I think we should at least require both increments to be adjusted or neighter, and possibly tighten the decision when to do this.

* Update gmt_grdio.c
@welcome
Copy link

welcome bot commented Jul 10, 2020

💖 Thanks for opening this pull request! 💖

Please make sure you read our Contributing Guide and abide by our Code of Conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the comments below for your functions describing the it, all arguments, and return types before writing the code. This will help you think about your code design and results in better code.
  • We are grateful that you put in the effort to do this! 🎉

@seisman
Copy link
Member

seisman commented Jul 10, 2020 •
edited
Loading

@PaulWessel This is the PR automatically created by the backport action. The action cherry-picks the changes in PR #3631 and creates a PR for the 6.1 branch. You can merge it if all the CI jobs pass.

@PaulWessel PaulWessel merged commit e91f477 into 6.1 Jul 10, 2020
@PaulWessel PaulWessel deleted the backport-3631-to-6.1 branch July 10, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @PaulWessel