Skip to content

Commit d08b673

Browse files
committed
[pack #67] Don't pre-fetch packed objects during counting
This could be a real avenue, in single-threaded mode this probably shouldn't happen and the work should rather be postponed to entry generation, copying, which right now is ridiculously fast as it doesn't have to do much work anymore. > counting done 8.1M objects in 107.57s (75.5k objects/s)
1 parent 7fbc961 commit d08b673

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

git-pack/src/data/output/count/objects.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,8 @@ fn id_to_count<Find: crate::Find>(
463463
statistics.expanded_objects += 1;
464464
output::Count {
465465
id: id.to_owned(),
466-
entry_pack_location: db.location_by_oid(id, buf),
466+
// entry_pack_location: db.location_by_oid(id, buf),
467+
entry_pack_location: None,
467468
}
468469
}
469470

gitoxide-core/src/pack/create.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,7 @@ where
210210
counts.shrink_to_fit();
211211
counts
212212
};
213+
todo!("figure out performance issues");
213214

214215
progress.inc();
215216
let num_objects = counts.len();

0 commit comments

Comments
 (0)