Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Mar 24, 2020

This PR contains the following updates:

Package Update Change
com.google.cloud:libraries-bom minor 3.4.0 -> 3.5.0
com.google.cloud:libraries-bom minor 3.3.0 -> 3.5.0

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team March 24, 2020 23:48
@forking-renovate forking-renovate bot added the automerge Merge the pull request once unit tests and other checks pass. label Mar 24, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@renovate-bot renovate-bot changed the title Update dependency com.google.cloud:libraries-bom to v3.5.0 chore(deps): update dependency com.google.cloud:libraries-bom to v3.5.0 Mar 25, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 25, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@averikitsch
Copy link
Contributor

@kurtisvg @lesv There are a handle of broken samples. Should I close this or should I just remove the samples that need fixing?

@kurtisvg
Copy link
Contributor

If the sample are broken unrelated to the dependency upgrade, I would just file a bug for the broken tests and merge this in anyway. I believe a partial upgrade will cause renovate to just ignore this dependency, and I don't think it makes sense to ignore future updates because a one out of many samples is broken.

@lesv
Copy link
Contributor

lesv commented Mar 25, 2020

@averikitsch I'm of two minds on this, on the one hand, v4.3.0 is out and I'd rather we just upgraded to that. Unless I'm missing that it's a whole separate deal.

That said, I agree w/ @kurtisvg - let's move forward and deal w/ the broken / missing tests on seperate PR's.

@lesv
Copy link
Contributor

lesv commented Mar 25, 2020

(if they aren't related to the upgrade)

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 25, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 25, 2020
@renovate-bot renovate-bot changed the title Update dependency com.google.cloud:libraries-bom to v3.5.0 chore(deps): update dependency com.google.cloud:libraries-bom to v3.5.0 Mar 25, 2020
@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@averikitsch
Copy link
Contributor

@lesv can we force merge this?

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@lesv
Copy link
Contributor

lesv commented Mar 26, 2020

Sure

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 26, 2020
@nnegrey
Copy link
Contributor

nnegrey commented Mar 26, 2020

Automl Vision should be fixed now, the model has been re-deployed.
Basically after some period of time the API un-deploys the model automatically (not a feature I like) and the old tests that first came out didn't know about this "feature" so they don't check the model's state before running the test. I'm updating the test to ensure the model is deployed before trying to use it.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 1, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 1, 2020
@lesv
Copy link
Contributor

lesv commented Apr 1, 2020

Java8

- testing healthcare/v1beta1
------------------------------------------------------------
[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.853 s <<< FAILURE! - in snippets.healthcare.Hl7v2MessageTests
[ERROR] test_Hl7v2MessageList(snippets.healthcare.Hl7v2MessageTests)  Time elapsed: 0.507 s  <<< ERROR!
java.lang.NullPointerException
	at java.util.ArrayList.addAll(ArrayList.java:581)
	at snippets.healthcare.hl7v2.messages.HL7v2MessageList.hl7v2MessageList(HL7v2MessageList.java:67)
	at snippets.healthcare.Hl7v2MessageTests.test_Hl7v2MessageList(Hl7v2MessageTests.java:140)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------------------------------------------------------------
- testing video/beta
------------------------------------------------------------
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 173.775 s <<< FAILURE! - in com.example.video.DetectIT
[ERROR] com.example.video.DetectIT.testTrackObjects  Time elapsed: 7.234 s  <<< ERROR!
java.util.concurrent.ExecutionException: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
	at com.example.video.DetectIT.testTrackObjects(DetectIT.java:82)
Caused by: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.

Java 11

------------------------------------------------------------
- testing appengine-java11/guestbook-cloud-firestore
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.thoughtworks.xstream.core.util.Fields (file:/root/.m2/repository/com/thoughtworks/xstream/xstream/1.3.1/xstream-1.3.1.jar) to field java.util.Properties.defaults
WARNING: Please consider reporting this to the maintainers of com.thoughtworks.xstream.core.util.Fields
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

------------------------------------------------------------
- testing dataproc
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.bugpatterns.FutureReturnValueIgnored (file:/root/.m2/repository/com/google/errorprone/error_prone_core/2.3.4/error_prone_core-2.3.4.jar) to field com.sun.tools.javac.code.Type$StructuralTypeMapping$4.this$0
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.bugpatterns.FutureReturnValueIgnored
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.
------------------------------------------------------------
- testing dlp
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.bugpatterns.FutureReturnValueIgnored (file:/root/.m2/repository/com/google/errorprone/error_prone_core/2.3.4/error_prone_core-2.3.4.jar) to field com.sun.tools.javac.code.Type$StructuralTypeMapping$4.this$0
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.bugpatterns.FutureReturnValueIgnored
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

------------------------------------------------------------
- testing firestore
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.bugpatterns.FutureReturnValueIgnored (file:/root/.m2/repository/com/google/errorprone/error_prone_core/2.3.4/error_prone_core-2.3.4.jar) to field com.sun.tools.javac.code.Type$StructuralTypeMapping$4.this$0
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.bugpatterns.FutureReturnValueIgnored
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

------------------------------------------------------------
- testing healthcare/v1beta1
------------------------------------------------------------
[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.332 s <<< FAILURE! - in snippets.healthcare.Hl7v2MessageTests
[ERROR] test_Hl7v2MessageList(snippets.healthcare.Hl7v2MessageTests)  Time elapsed: 1.112 s  <<< ERROR!
java.lang.NullPointerException
	at java.base/java.util.ArrayList.addAll(ArrayList.java:701)
------------------------------------------------------------
- testing video/beta
------------------------------------------------------------
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 224.431 s <<< FAILURE! - in com.example.video.DetectIT
[ERROR] com.example.video.DetectIT.testTrackObjects  Time elapsed: 0.94 s  <<< ERROR!
java.util.concurrent.ExecutionException: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
	at com.example.video.DetectIT.testTrackObjects(DetectIT.java:82)
Caused by: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Request contains an invalid argument.
------------------------------------------------------------
- testing vision/beta/cloud-client
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.util.FindIdentifiers (file:/root/.m2/repository/com/google/errorprone/error_prone_check_api/2.3.4/error_prone_check_api-2.3.4.jar) to method com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.javac.util.Name,com.sun.tools.javac.code.Kinds$KindSelector)
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.util.FindIdentifiers
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

------------------------------------------------------------
- testing vision/cloud-client
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.util.FindIdentifiers (file:/root/.m2/repository/com/google/errorprone/error_prone_check_api/2.3.4/error_prone_check_api-2.3.4.jar) to method com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.javac.util.Name,com.sun.tools.javac.code.Kinds$KindSelector)
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.util.FindIdentifiers
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

------------------------------------------------------------
- testing vision/product-search/cloud-client
------------------------------------------------------------
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.errorprone.util.FindIdentifiers (file:/root/.m2/repository/com/google/errorprone/error_prone_check_api/2.3.4/error_prone_check_api-2.3.4.jar) to method com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.javac.util.Name,com.sun.tools.javac.code.Kinds$KindSelector)
WARNING: Please consider reporting this to the maintainers of com.google.errorprone.util.FindIdentifiers
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

 Testing completed.

@lesv
Copy link
Contributor

lesv commented Apr 1, 2020

I'm going to merge this and open bugs for video/beta & healthcare/v1beta1.

@lesv lesv merged commit a7f5631 into GoogleCloudPlatform:master Apr 1, 2020
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-libraries-bom-3.x branch April 1, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants