Skip to content

Address comments #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2017
Merged

Address comments #388

merged 3 commits into from
May 18, 2017

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented May 15, 2017

No description provided.

@ace-n ace-n requested review from gguuss, jmdobry and sgreenberg May 15, 2017 18:25
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 15, 2017
@ace-n
Copy link
Contributor Author

ace-n commented May 15, 2017 •
edited
Loading

Note: the video README needs to be updated before this is merged.

@jmdobry can you tell me how to regenerate it, or should I just update it manually (with the new help text)?

EDIT: samples generate seems to be the right command, but it gives me an error. I'll take a closer look and/or ping you if I get stuck. Thanks!

@jmdobry
Copy link
Member

jmdobry commented May 15, 2017

@ace-n you'll need to add stuff to the package.json file, see one of the sample package.json files for what to add. Also, make sure you have the latest @google-cloud/nodejs-repo-tools

@ace-n
Copy link
Contributor Author

ace-n commented May 16, 2017

@jmdobry done - though I had to massage package.json a little to avoid the error. (Also had to force-push with the latest changes 😨 - but there shouldn't be any non-package.json/README changes 👍 )

@codecov-io
Copy link

codecov-io commented May 16, 2017 •
edited
Loading

Codecov Report

Merging #388 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files           4        4           
  Lines         422      422           
=======================================
  Hits          354      354           
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8491a...62caebb. Read the comment docs.

@ace-n ace-n merged commit 8b6b0a2 into master May 18, 2017
@ace-n ace-n deleted the video-update branch May 18, 2017 00:26
This was referenced Dec 23, 2020
Open
Open
Open
Open
Open
This was referenced Sep 5, 2021
Open
Open
Open
Open
Open
grayside pushed a commit that referenced this pull request Oct 26, 2022
@alexander-fenster
feat!: drop node8 support, support for async iterators (#388)
ba5a859 
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
@grayside grayside mentioned this pull request Oct 26, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 3, 2022
@alexander-fenster @grayside
feat!: drop node8 support, support for async iterators (#388)
4468356 
BREAKING CHANGE: The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.

New feature: methods with pagination now support async iteration.
ace-n pushed a commit that referenced this pull request Nov 16, 2022
Address comments (#388)
9dc4dfe 
* Address sgreenberg's comments

* Massage package.json + generate README
@ace-n ace-n mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Address comments (#388)
e3efddc 
* Address sgreenberg's comments

* Massage package.json + generate README
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
Address comments (#388)
6b428b9 
* Address sgreenberg's comments

* Massage package.json + generate README
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith
fix(deps): drop dependency on through2 (#388)
ba46858
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith
fix(deps): drop dependency on through2 (#388)
d0205bb
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@JustinBeckwith @NimJay
fix(deps): drop dependency on through2 (#388)
06103df
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@kapishps @gcf-owl-bot
docs(samples): Added sample for creating Secret with UserManaged repl…
3796e9b 
…ication (#388)

* added create ummr secret sample

* added test for create ummr secret

* fix dependency version

* lint changes

* updated copyright

* updated comment

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmdobry jmdobry jmdobry approved these changes

@sgreenberg sgreenberg Awaiting requested review from sgreenberg

@gguuss gguuss Awaiting requested review from gguuss

Assignees

No one assigned

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ace-n @jmdobry @codecov-io