Adds updates including compute #2436

gguuss · 2019-10-04T19:45:00Z

No description provided.

asset/cloud-client/quickstart_createfeed_test.py

gguuss · 2019-10-08T19:03:20Z

Now I remember - all of the CRUD methods started failing for this sample. As far as I can tell, the library updates should not affect the API calls. In fact, downgrading to the previous commit does not affect test results:

______________________________________________________________________________________ test_create_feed _______________________________________________________________________________________
Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
    raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
        status = StatusCode.INVALID_ARGUMENT
        details = "Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305)."
        debug_error_string = "{"created":"@1570561326.443398903","description":"Error received from peer ipv6:[2607:f8b0:400a:804::200a]:443","file":"src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).","grpc_status":3}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_createfeed_test.py", line 40, in test_create_feed
    PROJECT, FEED_ID, [ASSET_NAME, ], full_topic_name)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_createfeed.py", line 36, in create_feed
    response = client.create_feed(parent, feed_id, feed)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/cloud/asset_v1p2beta1/gapic/asset_service_client.py", line 524, in create_feed
    request, retry=retry, timeout=timeout, metadata=metadata
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 277, in retry_wrapped_func
    on_error=on_error,
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 182, in retry_target
    return target()
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).
______________________________________________________________________________________ test_delete_feed _______________________________________________________________________________________
Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
    raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
        status = StatusCode.INVALID_ARGUMENT
        details = "Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305)."
        debug_error_string = "{"created":"@1570561327.361421362","description":"Error received from peer ipv6:[2607:f8b0:400a:804::200a]:443","file":"src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).","grpc_status":3}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_deletefeed_test.py", line 38, in test_delete_feed
    PROJECT, FEED_ID, [ASSET_NAME, ], full_topic_name)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_createfeed.py", line 36, in create_feed
    response = client.create_feed(parent, feed_id, feed)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/cloud/asset_v1p2beta1/gapic/asset_service_client.py", line 524, in create_feed
    request, retry=retry, timeout=timeout, metadata=metadata
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 277, in retry_wrapped_func
    on_error=on_error,
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 182, in retry_target
    return target()
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).
________________________________________________________________________________________ test_get_feed ________________________________________________________________________________________
Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
    raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
        status = StatusCode.INVALID_ARGUMENT
        details = "Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305)."
        debug_error_string = "{"created":"@1570561361.012064894","description":"Error received from peer ipv6:[2607:f8b0:400a:804::200a]:443","file":"src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).","grpc_status":3}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_getfeed_test.py", line 39, in test_get_feed
    PROJECT, FEED_ID, [ASSET_NAME, ], full_topic_name)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_createfeed.py", line 36, in create_feed
    response = client.create_feed(parent, feed_id, feed)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/cloud/asset_v1p2beta1/gapic/asset_service_client.py", line 524, in create_feed
    request, retry=retry, timeout=timeout, metadata=metadata
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 277, in retry_wrapped_func
    on_error=on_error,
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 182, in retry_target
    return target()
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).
______________________________________________________________________________________ test_update_feed _______________________________________________________________________________________
Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 57, in error_remapped_callable
    return callable_(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 604, in __call__
    return _end_unary_response_blocking(state, call, False, None)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/grpc/_channel.py", line 506, in _end_unary_response_blocking
    raise _Rendezvous(state, None, None, deadline)
grpc._channel._Rendezvous: <_Rendezvous of RPC that terminated with:
        status = StatusCode.INVALID_ARGUMENT
        details = "Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305)."
        debug_error_string = "{"created":"@1570561362.660226737","description":"Error received from peer ipv6:[2607:f8b0:400a:804::200a]:443","file":"src/core/lib/surface/call.cc","file_line":1055,"grpc_message":"Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).","grpc_status":3}"
>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_updatefeed_test.py", line 40, in test_update_feed
    PROJECT, FEED_ID, [ASSET_NAME, ], full_topic_name)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/asset/cloud-client/quickstart_createfeed.py", line 36, in create_feed
    response = client.create_feed(parent, feed_id, feed)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/cloud/asset_v1p2beta1/gapic/asset_service_client.py", line 524, in create_feed
    request, retry=retry, timeout=timeout, metadata=metadata
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/gapic_v1/method.py", line 143, in __call__
    return wrapped_func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 277, in retry_wrapped_func
    on_error=on_error,
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/retry.py", line 182, in retry_target
    return target()
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/timeout.py", line 214, in func_with_timeout
    return func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-asset-cloud-client/lib/python3.6/site-packages/google/api_core/grpc_helpers.py", line 59, in error_remapped_callable
    six.raise_from(exceptions.from_grpc_error(exc), exc)
  File "<string>", line 3, in raise_from
google.api_core.exceptions.InvalidArgument: 400 Fail to use projects/intense-wavelet-343/topics/topic-1570561305 as feed output destination. Error: Resource not found (resource=topic-1570561305).

Unable to determine how to set up the tests, I gave up on contributing fixes in this case. It's entirely possible there's a race condition or pre-sample setup that is missing.

gguuss

The CRUD tests in asset were almost definitely broken. I think the right thing to do is follow up internally with cwxie

gguuss · 2019-10-10T21:48:03Z

Tracking down cwxie worked, the tests are now re-enabled and fixed!

gguuss · 2019-10-16T21:37:12Z

@tswast Any idea why the composer tests might be failing (e.g. API changes, not unexpected responses)?

tswast · 2019-10-16T21:44:27Z

@gguuss It's due to a dependency problem in apache-airflow[gcp_api]==1.10.3 #2471 (comment) Supposedly fixed in 1.10.4

gguuss · 2019-10-16T22:13:29Z

@tswast I tried pinning an older version of flask, still seeing:

Traceback (most recent call last):
  File "/usr/local/google/home/class/code/samples/python-docs-samples/composer/workflows/kubernetes_pod_operator_test.py", line 24, in test_dag_import
    from . import kubernetes_pod_operator as module
  File "/usr/local/google/home/class/code/samples/python-docs-samples/composer/workflows/kubernetes_pod_operator.py", line 215, in <module>
    affinity={})
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-composer-workflows/lib/python3.6/site-packages/airflow/utils/decorators.py", line 98, in wrapper
    result = func(*args, **kwargs)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-composer-workflows/lib/python3.6/site-packages/airflow/contrib/operators/kubernetes_pod_operator.py", line 229, in __init__
    self.resources = self._set_resources(resources)
  File "/usr/local/google/home/class/code/samples/python-docs-samples/.nox/py36-sample-composer-workflows/lib/python3.6/site-packages/airflow/contrib/operators/kubernetes_pod_operator.py", line 169, in _set_resources
    for item in resources.keys():
AttributeError: 'Resources' object has no attribute 'keys'

I'll see about downgrading to 1.10.2

tswast · 2019-10-16T22:17:02Z

@leahecole Gus's traceback seems to indicate there's a new Resources object in some Kubernetes logic that used to be a dictionary. Any ideas? Or should we just disable the kubernetespodoperator test for now?

leahecole · 2019-10-17T08:48:03Z

Ugh given that it's blocking other people, I'd say disable it and assign either an issue, a buganizer bug, or both to me to fix once I'm back from this trip. I'll be able to take a look at it the week of the 28th, but I don't want it to block folks before then.

gguuss · 2019-10-17T20:32:11Z

I found a "fix", which is to pass the dictionary from the pod resource object instead of the object itself.

leahecole · 2019-10-18T14:13:06Z

heh. Noted. @gguuss do you need any action from me at this point? If so, let me know and I'll prioritize it for Monday.

gguuss · 2019-10-18T17:52:45Z

I'll assign an issue for you in GH to follow up on before EOQ, no rush :)

…

On Fri, Oct 18, 2019 at 7:13 AM Leah E. Cole ***@***.***> wrote: heh. Noted. @gguuss <https://github.com/gguuss> do you need any action from me at this point? If so, let me know and I'll prioritize it for Monday. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2436?email_source=notifications&email_token=AA2VD6QNGPCJH4P4BH2VI2TQPHAAFA5CNFSM4I5TWEL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBUTMZA#issuecomment-543766116>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2VD6UBNAHCSS7GPNGFCKTQPHAAFANCNFSM4I5TWELQ> .

-- Gus Class email : [email protected] phone: 425.200.4487 web : https://gusclass.com

gguuss · 2019-10-23T17:42:10Z

@crwilcox friendly ping :)

Adds updates including compute

7835511

gguuss self-assigned this Oct 4, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2019

gguuss requested a review from dpebot October 4, 2019 19:55

Python 2 compat pytest

e843e44

gguuss requested a review from crwilcox October 4, 2019 22:12

Merge branch 'master' into cpebot-fixstyle-atoe

1aa5d6a

crwilcox reviewed Oct 8, 2019

View reviewed changes

asset/cloud-client/quickstart_createfeed_test.py Outdated Show resolved Hide resolved

gguuss added 2 commits October 8, 2019 12:05

Merge branch 'master' into cpebot-fixstyle-atoe

7df9d14

Fixing weird \r\n issue from GH merge

d06d8ac

gguuss commented Oct 9, 2019

View reviewed changes

Merge branch 'master' into cpebot-fixstyle-atoe

c3278ed

Put asset tests back in

c7382ed

gguuss requested a review from crwilcox October 16, 2019 17:59

Re-add pod operator test

b698ae6

gguuss closed this Oct 16, 2019

gguuss reopened this Oct 16, 2019

Hack parameter for k8s pod operator

e26cd5f

crwilcox approved these changes Oct 23, 2019

View reviewed changes

msampathkumar mentioned this pull request Nov 14, 2022

migrate code from googleapis/python-datacatalog #8508

Merged

8 tasks

msampathkumar mentioned this pull request Nov 18, 2022

migrate code from googleapis/python-containeranalysis #8529

Merged

8 tasks

dizcology mentioned this pull request Jun 16, 2023

migrate code from googleapis/python-bigquery-datatransfer #10259

Merged

9 tasks

Linchin mentioned this pull request Aug 18, 2025

chore: migrate handwritten samples from googleapis/python-bigquery-storage #13543

Merged

9 tasks

Adds updates including compute #2436

Adds updates including compute #2436

Uh oh!

Conversation

gguuss commented Oct 4, 2019

Uh oh!

Uh oh!

gguuss commented Oct 8, 2019

Uh oh!

gguuss left a comment

Choose a reason for hiding this comment

Uh oh!

gguuss commented Oct 10, 2019

Uh oh!

gguuss commented Oct 16, 2019

Uh oh!

tswast commented Oct 16, 2019

Uh oh!

gguuss commented Oct 16, 2019

Uh oh!

tswast commented Oct 16, 2019

Uh oh!

leahecole commented Oct 17, 2019

Uh oh!

gguuss commented Oct 17, 2019

Uh oh!

leahecole commented Oct 18, 2019

Uh oh!

gguuss commented Oct 18, 2019 via email

Uh oh!

gguuss commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants