-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update KubernetesPodOperator kubernetes_min_pod example #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tswast , the Travis CI build is failing on the pythonvirtualenvoperator_python2_test.py - are these shells of tests that are in here? Any ideas of how to proceed? |
|
@leahecole Yes, the Travis output is from the tests here. The I recommend getting a Python development environment setup with multiple Python versions (see: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/MAC_SETUP.md) for how I have my system setup. Then see the instructions at https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#using-nox for running In your case, run (in a Python 3 virtual environment) from the That should replicate what Travis is doing. |
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since test failures are unrelated to this change. Probably need a follow-up PR to clean those up, though.
|
@tswast sorry for the delay - I lost sight of this. Cool to merge? All I changed was commenting out the things that made the linter barf :) |
| # limitations under the License. | ||
|
|
||
| import sys | ||
| # import sys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete these lines rather than comment them out.
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Okay to merge!
In this oprator, the kubernetes_min_pod fails without the 'cmds' parameter set